Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play" mode repaints gui each frame #2083

Closed
emilk opened this issue May 11, 2023 · 4 comments · Fixed by #2085
Closed

"Play" mode repaints gui each frame #2083

emilk opened this issue May 11, 2023 · 4 comments · Fixed by #2085
Labels
🪳 bug Something isn't working ui concerns graphical user interface

Comments

@emilk
Copy link
Member

emilk commented May 11, 2023

Try running examples/python/notebook/cube.ipynb and turn on the performance metrics, and you'll see:

repaint-play-bug

(see top left corner)

When "Play" hits the end it should probably stop, or at least we shouldn't be calling request_repaint unless there are new log events arriving.

@emilk emilk added the 🪳 bug Something isn't working label May 11, 2023
@emilk emilk changed the title Notebook "Play" mode repaints gui each frame "Play" mode repaints gui each frame May 11, 2023
@emilk emilk added the ui concerns graphical user interface label May 11, 2023
@emilk
Copy link
Member Author

emilk commented May 11, 2023

The fix should be the same as for #2077

@emilk
Copy link
Member Author

emilk commented May 11, 2023

This regression happened in a recent refactor of re_viewer, where the request_repaint was moved

@jleibs
Copy link
Member

jleibs commented May 12, 2023

The fix for this regressed other behavior.
See: #2103

@jleibs jleibs reopened this May 12, 2023
@jleibs
Copy link
Member

jleibs commented May 12, 2023

Fix for the regression: #2106

@jleibs jleibs closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants