Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play button should toggle when no data is streamed #2077

Closed
Wumpf opened this issue May 10, 2023 · 3 comments · Fixed by #2085
Closed

Play button should toggle when no data is streamed #2077

Wumpf opened this issue May 10, 2023 · 3 comments · Fixed by #2085
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented May 10, 2023

Via Kai on Discord https://discord.com/channels/1062300748202921994/1062300748777529379/1105509445137608724

In cases where we know no new data is streamed in (i.e. just loading a file / closed connection), the play button should toggle and not keep playing. More like a video player
@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 😤 annoying Something in the UI / SDK is annoying to use labels May 10, 2023
@emilk
Copy link
Member

emilk commented May 10, 2023

Makes sense. Related to:

@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label May 11, 2023
This was referenced May 11, 2023
Closed
Merged
@jleibs jleibs reopened this May 12, 2023
@jleibs
Copy link
Member

jleibs commented May 12, 2023 •
edited
Loading

The fix for this was more complicated than anticipated and introduced a bug where the viewer would prematurely pause if playback caught up with the recording timeline during log-ingestion.

WIth the change from #2085 the web-viewer could get stuck in the following state:
image

Re-opening this until we have a more complete fix.

@jleibs
Copy link
Member

jleibs commented May 12, 2023

Fix for the regression: #2106

@jleibs jleibs closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop playback when we reach the end of the data rerun-io/rerun
3 participants
@emilk @Wumpf @jleibs