Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from instant -> web_time #2093

Merged
merged 4 commits into from
May 17, 2023
Merged

Move from instant -> web_time #2093

merged 4 commits into from
May 17, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented May 11, 2023

What

instant has at least one issue affecting us:

web-time: https://github.com/daxpedda/web-time appears to achieve the same goals, but is under active development and notably doesn't have the bug that instant had.

This replaces all usage of instance with web_time.

Checklist

PR Build Summary: https://build.rerun.io/pr/2093

@jleibs jleibs added the 🕸️ web regarding running the viewer in a browser label May 11, 2023
@jleibs jleibs force-pushed the jleibs/use_web_time branch from cd1f0ed to 3bbb94c Compare May 11, 2023 19:23
@jleibs jleibs marked this pull request as ready for review May 11, 2023 19:23
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Let's also forbid instant in scripts/clippy_wasm/clippy.toml under disallowed-types.

We could also add it to the [bans] list in deny.toml… but banning instant from all our dependencies may be taking it a bit too far

@emilk
Copy link
Member

emilk commented May 11, 2023

Oh, and make sure you test it on the web!

@jleibs jleibs force-pushed the jleibs/use_web_time branch from 59c1f6d to 96c035a Compare May 11, 2023 21:14
@jleibs jleibs added the do-not-merge Do not merge this PR label May 11, 2023
@jleibs
Copy link
Member Author

jleibs commented May 11, 2023

Turns out there does appear to be a regression... if you open a web-viewer in a hidden tab and allow enough time to pass (3 to 4 seconds?) then when changing to that tab we don't have any content for the spatial views:
image

Seems like we end up in a state where maybe an unknown time is ends up selected or something goes weird with forwarding playing of time.

There's a known issue listed in the repo, so I'm wondering if this is related.

Currently a known bug is affecting browsers on operating system other then Windows. This bug prevents Instant from continuing to tick when the context is asleep. This doesn't necessarily conflict with Rusts requirements of Instant, but might still be unexpected.

So far only seems to repro when loading a hosted RRD in the web-viewer:

open http://127.0.0.1:9090/?url=https://app.rerun.io/data/commit/cafe140/colmap_fiat.rrd

@jleibs
Copy link
Member Author

jleibs commented May 12, 2023

The above issue appears likely to have been caused by: #2103

With that merged, we should investigate this again

@emilk
Copy link
Member

emilk commented May 15, 2023

The issue was fixed by #2106 so I think this PR just needs a rebase and a new test

@emilk emilk added dependencies concerning crates, pip packages etc and removed do-not-merge Do not merge this PR labels May 17, 2023
@emilk
Copy link
Member

emilk commented May 17, 2023

Works great in Firefox and Chromium on my Mac.

@emilk emilk merged commit 5c652d2 into main May 17, 2023
@emilk emilk deleted the jleibs/use_web_time branch May 17, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants