Fix problem of rrd playback stopping prematurely. #2103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3abd1c1.
emilk
approved these changes
May 12, 2023
|
Give me a few minutes before merging this - a proper fix might be easier than we think |
1 task
|
Closing in favor of: #2106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#2085 introduced a race condition with playback of RRD files where we would hit the end of the current time range, usually right at the beginning of playback, resulting in the viewer stuck in this state:
Reverting that for now and adding some more details.
Checklist
PR Build Summary: https://build.rerun.io/pr/2103