Skip to content

Change MACOSX_DEPLOYMENT_TARGET to 10.9#5406

Merged
TeBoring merged 10 commits intomasterfrom
python-wheel-kokoro-dev
Nov 29, 2018
Merged

Change MACOSX_DEPLOYMENT_TARGET to 10.9#5406
TeBoring merged 10 commits intomasterfrom
python-wheel-kokoro-dev

Conversation

@TeBoring
Copy link
Contributor

@TeBoring TeBoring commented Nov 27, 2018 •
edited
Loading

TeBoring and others added 4 commits August 13, 2018 12:59
@TeBoring
Add kokoro build for python source package
ae54cd9
@JerryShih @TeBoring
Use libc++ for xcode 10 (#5303)
28f8e5c 
The xcode 10 removes the deprecated libstdc++ library. We could set
"MACOSX_DEPLOYMENT_TARGET" to "10.9" to use libc++ instead.
@TeBoring
Add python 3.7 build
5940f55
@TeBoring
Add build for python 3.7 on linux and windows
60e3073
@googlebot
Copy link

googlebot commented Nov 27, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@TeBoring
Copy link
Contributor Author

TeBoring commented Nov 27, 2018

@JerryShih could you confirm cla?

@TeBoring TeBoring requested a review from anandolee November 27, 2018 22:30
@JerryShih
Copy link

JerryShih commented Nov 27, 2018 •
edited
Loading

@TeBoring
What I need to do here?
I already signed the cla in #5238.

@TeBoring
Copy link
Contributor Author

TeBoring commented Nov 27, 2018

@JerryShih just a confirm is ok. The googlebot has some problems with merging PR.

@JerryShih
Copy link

JerryShih commented Nov 28, 2018

confirm is ok

@TeBoring @googlebot

@TeBoring TeBoring changed the title Python wheel kokoro dev Change mac target version to 10.9 Nov 28, 2018
@TeBoring TeBoring changed the title Change mac target version to 10.9 Change MACOSX_DEPLOYMENT_TARGET to 10.9 Nov 28, 2018
@TeBoring TeBoring assigned anandolee and unassigned TeBoring Nov 28, 2018
@TeBoring TeBoring merged commit 704037f into master Nov 29, 2018
This was referenced Dec 1, 2018
Closed
Merged
acozzette pushed a commit to acozzette/protobuf that referenced this pull request Dec 4, 2018
@TeBoring
Change MACOSX_DEPLOYMENT_TARGET to 10.9 (protocolbuffers#5406)
4bb130e 
* Add kokoro build for python source package

* Use libc++ for xcode 10 (protocolbuffers#5303)

The xcode 10 removes the deprecated libstdc++ library. We could set
"MACOSX_DEPLOYMENT_TARGET" to "10.9" to use libc++ instead.

* Add python 3.7 build

* Add build for python 3.7 on linux and windows

* Remove unused source build

* Add comment

* Fix $MACOSX_DEPLOYMENT_TARGET mismatch

* Fix MACOSX_DEPLOYMENT_TARGET mismatch

* Add missing import for sysconfig

* Add missing imports
@acozzette acozzette mentioned this pull request Dec 4, 2018
Merged
acozzette pushed a commit that referenced this pull request Dec 4, 2018
Merge pull request #5424 from acozzette/mac-python-fix
b829ff2 
Cherry-picked fix from #5406
@fowles fowles deleted the python-wheel-kokoro-dev branch April 6, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandolee anandolee anandolee approved these changes

Assignees

@anandolee anandolee

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TeBoring @googlebot @JerryShih @anandolee @kokoro-team