Use libc++ for xcode 10(python-wheel-kokoro-dev branch)#5303
Merged
TeBoring merged 1 commit intoprotocolbuffers:python-wheel-kokoro-devfrom Nov 12, 2018
Merged
Conversation
The xcode 10 removes the deprecated libstdc++ library. We could set "MACOSX_DEPLOYMENT_TARGET" to "10.9" to use libc++ instead.
Author
|
@TeBoring |
Contributor
|
Thanks! |
Author
|
@TeBoring |
Contributor
|
Sorry, I didn't have time to work on that last week. Test it this week. |
Contributor
|
I will test internally. When it's done, I'll create a PR to merge it into master. |
TeBoring
added a commit
that referenced
this pull request
Nov 29, 2018
* Add kokoro build for python source package * Use libc++ for xcode 10 (#5303) The xcode 10 removes the deprecated libstdc++ library. We could set "MACOSX_DEPLOYMENT_TARGET" to "10.9" to use libc++ instead. * Add python 3.7 build * Add build for python 3.7 on linux and windows * Remove unused source build * Add comment * Fix $MACOSX_DEPLOYMENT_TARGET mismatch * Fix MACOSX_DEPLOYMENT_TARGET mismatch * Add missing import for sysconfig * Add missing imports
acozzette
pushed a commit
to acozzette/protobuf
that referenced
this pull request
Dec 4, 2018
* Add kokoro build for python source package * Use libc++ for xcode 10 (protocolbuffers#5303) The xcode 10 removes the deprecated libstdc++ library. We could set "MACOSX_DEPLOYMENT_TARGET" to "10.9" to use libc++ instead. * Add python 3.7 build * Add build for python 3.7 on linux and windows * Remove unused source build * Add comment * Fix $MACOSX_DEPLOYMENT_TARGET mismatch * Fix MACOSX_DEPLOYMENT_TARGET mismatch * Add missing import for sysconfig * Add missing imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xcode 10 removes the deprecated libstdc++ library. We could set
"MACOSX_DEPLOYMENT_TARGET" to "10.9" to use libc++ instead.