Skip to content

Cherry-picked fix from #5406#5424

Merged
acozzette merged 1 commit intoprotocolbuffers:3.6.xfrom
acozzette:mac-python-fix
Dec 4, 2018
Merged

Cherry-picked fix from #5406#5424
acozzette merged 1 commit intoprotocolbuffers:3.6.xfrom
acozzette:mac-python-fix

Conversation

@acozzette
Copy link

No description provided.

* Add kokoro build for python source package

* Use libc++ for xcode 10 (protocolbuffers#5303)

The xcode 10 removes the deprecated libstdc++ library. We could set
"MACOSX_DEPLOYMENT_TARGET" to "10.9" to use libc++ instead.

* Add python 3.7 build

* Add build for python 3.7 on linux and windows

* Remove unused source build

* Add comment

* Fix $MACOSX_DEPLOYMENT_TARGET mismatch

* Fix MACOSX_DEPLOYMENT_TARGET mismatch

* Add missing import for sysconfig

* Add missing imports
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no label Dec 4, 2018
@acozzette
Copy link
Author

The CLA is OK because it was already verified when the change was originally merged as #5406.

@acozzette acozzette merged commit b829ff2 into protocolbuffers:3.6.x Dec 4, 2018
@acozzette acozzette deleted the mac-python-fix branch December 4, 2018 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants