Skip to content

Change MACOSX_DEPLOYMENT_TARGET to 10.9 #5406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeBoring merged 10 commits into from
Nov 29, 2018
Merged

Change MACOSX_DEPLOYMENT_TARGET to 10.9 #5406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae54cd9
Add kokoro build for python source package
TeBoring Aug 13, 2018
28f8e5c
Use libc++ for xcode 10 (#5303)
JerryShih Nov 12, 2018
5940f55
Add python 3.7 build
TeBoring Nov 27, 2018
60e3073
Add build for python 3.7 on linux and windows
TeBoring Nov 27, 2018
3d383b4
Remove unused source build
TeBoring Nov 27, 2018
836af41
Add comment
TeBoring Nov 27, 2018
d6d0ee2
Fix $MACOSX_DEPLOYMENT_TARGET mismatch
TeBoring Nov 28, 2018
9afc16d
Fix MACOSX_DEPLOYMENT_TARGET mismatch
TeBoring Nov 28, 2018
f6a2f57
Add missing import for sysconfig
TeBoring Nov 28, 2018
e60985a
Add missing imports
TeBoring Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kokoro/release/python/linux/build_artifacts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ build_artifact_version 2.7
build_artifact_version 3.4
build_artifact_version 3.5
build_artifact_version 3.6
build_artifact_version 3.7
1 change: 1 addition & 0 deletions kokoro/release/python/macos/build_artifacts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@ build_artifact_version 2.7
build_artifact_version 3.4
build_artifact_version 3.5
build_artifact_version 3.6
build_artifact_version 3.7
10 changes: 10 additions & 0 deletions kokoro/release/python/windows/build_artifacts.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,13 @@ SET PYTHON=C:\python36
SET PYTHON_VERSION=3.6
SET PYTHON_ARCH=64
CALL build_single_artifact.bat

SET PYTHON=C:\python37_32bit
SET PYTHON_VERSION=3.7
SET PYTHON_ARCH=32
CALL build_single_artifact.bat

SET PYTHON=C:\python37
SET PYTHON_VERSION=3.7
SET PYTHON_ARCH=64
CALL build_single_artifact.bat
16 changes: 16 additions & 0 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
#! /usr/bin/env python
#
# See README for usage instructions.
from distutils import util
import glob
import os
import pkg_resources
import re
import subprocess
import sys
import sysconfig
import platform

# We must use setuptools, not distutils, because we need to use the
Expand Down Expand Up @@ -186,6 +190,18 @@ def get_option_from_sys_argv(option_str):
extra_compile_args.append('-Wno-invalid-offsetof')
extra_compile_args.append('-Wno-sign-compare')

# https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes
# C++ projects must now migrate to libc++ and are recommended to set a
# deployment target of macOS 10.9 or later, or iOS 7 or later.
if sys.platform == 'darwin':
mac_target = sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET')
if mac_target and (pkg_resources.parse_version(mac_target) <
pkg_resources.parse_version('10.9.0')):
os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.9'
os.environ['_PYTHON_HOST_PLATFORM'] = re.sub(
r'macosx-[0-9]+\.[0-9]+-(.+)', r'macosx-10.9-\1',
util.get_platform())

# https://github.com/Theano/Theano/issues/4926
if sys.platform == 'win32':
extra_compile_args.append('-D_hypot=hypot')
Expand Down