Cherry-pick fix for compatibility with Python 3.7#5423
Cherry-pick fix for compatibility with Python 3.7#5423acozzette merged 1 commit intoprotocolbuffers:3.6.xfrom
Conversation
Compilation of Python wrappers fails with Python 3.7 because the Python folks changed their C API such that PyUnicode_AsUTF8AndSize() now returns a const char* rather than a char*. Add a patch to work around. Relates protocolbuffers#4086.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
|
The CLA is OK because it was already verified when this fix was merged as part of PR #4862. |
|
Why #4940 still fail? |
|
I'm not sure about #4940 but it looks like those tests are probably failing because of some kind of issue with the test setup and not necessarily a real problem with Python 3.7. The TensorFlow team requested this cherry-pick because they have users who want to upgrade to Python 3.7. |
|
To build python 3.7, you probably also needs #5406. Otherwise, the built wheel cannot be run on latest mac (usually python 3.7 is on the newest mac) |
5 participants
This cherry-picks the fix from PR #4862 so that we can include it in a 3.6.1.2 patch release.