refactor(web): the new-thread hook keeps its caching without "use memo"

[juliusmarminge]

useOrderedProjects carried a "use memo" directive. Inline, the ordered project list would be built from useProjects() before the useNewThreadHandler() call and read again after it (orderedProjects[0] → scopeProjectRef), so it straddled that hook and the ordering would run every render.

The helper is inlined. useNewThreadHandler() moved up beside the other hooks, and the ordering and defaultProjectRef are derived after it, so nothing crosses a hook call. Only the first project is destructured, since that is all the hook uses.

kept cached: the project ordering and defaultProjectRef (keyed on projects and projectOrder), and the returned object that _chat.tsx, CommandPalette, Sidebar and SnapShotCoordinator read. One small difference: defaultProjectRef used to keep its identity when projects changed but the first project object did not. It now changes whenever the projects array does.

🤖 Generated with Claude Code (Claude Opus 5.5)

[macroscopeapp]

Approvability

Verdict: Approved at af40c2b

Macroscope's review found this PR approvable — This one-file refactor preserves the existing project-ordering and default-project selection while removing an unnecessary memo directive and limiting the derived value to what callers use. Its only behavioral difference is bounded referential-identity churn when the projects array changes, with no schema, deployment, security, or product-default changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 8a2854a6-47ab-4edf-9d42-b57f72b887fd

📥 Commits

Reviewing files that changed from the base of the PR and between 0752826 and af40c2b.

📒 Files selected for processing: 1

• apps/web/src/hooks/useHandleNewThread.ts

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

The hook no longer uses the private useOrderedProjects helper. It orders projects directly with the existing preferences and derives the default project reference from the first result, or null when no project exists.

Changes: Default project selection

Layer / File(s)	Summary
Order projects and select a default apps/web/src/hooks/useHandleNewThread.ts	The hook applies the existing project ordering preferences directly. It converts the first project to a scoped reference, or returns null when the list is empty.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to af40c

No actionable issue is established with default project selection or caching. The change is mergeable after normal checks.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description explains the problem and the implementation change, but it omits the required Scope and approval and Verification sections. It does not provide focused test or manual-check results.	Add the required Scope and approval section with an issue or maintainer approval, or explain why this focused change is exempt. Add the Verification section with the checks performed, observed results, and any checks that were not run.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly identifies the refactor and its main goal: retaining caching in the new-thread hook without the "use memo" directive.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 1
• Charged: $0.25
• View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

_{Comment @coderabbitai help to get the list of available commands.}