perf(web): the provider update notification compiles without manual memoization

[juliusmarminge]

The primary provider update notification derived its update candidates, notification key and one-click providers in useMemo and wrapped its settings opener in useCallback, which kept it out of the React Compiler strict bar.

They are now plain expressions and a plain function. The compiler caches the derived values on the provider list and the settings opener on navigate, so the toast effects re-run on the same inputs as before. The file joins REACT_COMPILED_FILES. No behaviour change.

🤖 Generated with Claude Code (Claude Opus 5.5)

[macroscopeapp]

Approvability

Verdict: Approved at c64d1ac

Macroscope's review found this PR approvable — This is a focused one-file performance refactor that removes redundant manual memoization while the web build enables React Compiler, leaving provider updates, permissions, navigation, and toast behavior intact. It adds no capability, schema change, deployment change, product-default change, or static-analysis suppression.

Notes:

• All code in this push has already been reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: eeff6dd6-9e62-4a92-a27f-9ed862002156

📥 Commits

Reviewing files that changed from the base of the PR and between 449f033 and c64d1ac.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: ea55f5f9-fdf2-4e74-b598-5274514e6b8f

📥 Commits

Reviewing files that changed from the base of the PR and between 70d60e0 and 449f033.

📒 Files selected for processing: 2

• apps/web/reactCompiledFiles.ts
• apps/web/src/components/ProviderUpdatePrimaryNotification.tsx

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

The provider update notification now calculates candidate values and its settings handler directly on each render. Its component file is also included in the React Compiler file list.

Changes: Provider update notification

Layer / File(s)	Summary
Notification calculations and compiler configuration apps/web/src/components/ProviderUpdatePrimaryNotification.tsx, apps/web/reactCompiledFiles.ts	Provider-update candidates, the notification key, one-click candidates, and the settings handler are no longer memoized. The handler retains its toast cleanup and navigation behavior. The component is added to the React Compiler file list.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: jgratton24

Merge Risk: ⚪ Minimal · up to 449f0

No actionable merge-blocking issue was found. Run the normal compiler coverage test before merging.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description explains the problem and the implementation, but it omits the required Scope and approval and Verification sections. It does not identify issue or approval context, focused checks perf…	Add the required Scope and approval section with issue, discussion, or justification for the focused configuration change. Add the Verification section with the tests or manual checks performed, observed results, and anything not checked. I…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: enabling React Compiler compilation for the provider update notification without manual memoization.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem and the implementation, but it omits the required Scope and approval and Verification sections. It does not identify issue or approval context, focused checks performed, observed results, or limitations.

Resolution

Add the required Scope and approval section with issue, discussion, or justification for the focused configuration change. Add the Verification section with the tests or manual checks performed, observed results, and anything not checked. Include UI evidence only if the changed behavior affects UI presentation or interaction.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate c64d1ac