Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive flag for remove in Collections #13897

Closed
wants to merge 23 commits into from
Closed

Case insensitive flag for remove in Collections #13897

wants to merge 23 commits into from

Conversation

niden
Copy link
Member

@niden niden commented Mar 13, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Added case insensitive flag in remove()

Thanks

niden added 22 commits January 28, 2019 10:03
* upstream/4.0.x:
  [4.0.x] - Added unicode flag for email filter
* upstream/4.0.x:
  [#13488] - Removed commas that crept in the .env file
  [#13488] - Minor corection to debug; Added funcitonality for getting filtered vars; Added tests
  [#13488] - Initial changes for the feature; adding methods
* upstream/4.0.x:
  Updated changelog
  Updated CFLAG default build param
  keep the actionName as set, do cache the methodName in `getActiveMethod` instead (use action mapping to cover Dispatcher `forward`ing case?)
  move formatter into setter
  give up on `camelize`, use a new approach
  unit tests
  Camel-case the action name (before call in handler)
  Correct pull request template
  Fix .editorconfig
  Amended .gitignore
  Bump version
  Fixed preparing release on AppVeyor
  Update change log
  Regenerated build
  Regenerated ext
  Updating the changelog
* upstream/4.0.x:
  Updated the changelog
  [#13808] - Updating ext folder
  [#13808] - Adjusting tests
  [#13808] - Renaming ACL elements
* upstream/4.0.x:
  Update CHANGELOG-4.0.md
  Updated changelog
  Added geSetMetaData test Modified some unit tests to use metaData
  Modified existing tests to work with the additional MetaData
  Modified Phalcon\Mvc\Model to use Phalcon\Message::setMetaData() instead of setModel()
  Added new MetaData variable to Phalcon\Message. Modified Phalcon\MessageInterface accordingly
  Corrected typo
* upstream/4.0.x:
  [#2182] - Updated the changelog and PR template
  [#2182] - Added before/after compile events for Volt
  [#2182] - Removed some obsolete tests; Added tests for engine/render events
  Updated changelog
  fix tests
  change tests
  fix stan
  Add `Dispatcher::toCamelCase()` method
  [#13819] - Updated the changelog
  [#13819] - Removing css/js optimizers from the config
  [#13819] - Updating ext/
  [#13819] - Removed minifiers
  [#13819] - Marked tests as skipped
* upstream/4.0.x:
  Allow Config::merge to accept a basic array. (#13830)
* upstream/4.0.x:
  T13336 find first null (#13826)
  renamed phalcon\mvc\url to phalcon\url (#13831)
* upstream/4.0.x:
  Install MySQL 5.7 on Travis CI [skip appveyor] (#13835)
* upstream/4.0.x:
  4.0.x: adding missing method isSent to interface ResponseInterface (#13836)
  T13687 debug hide vars (#13833)
* upstream/4.0.x:
  T13364 beanstalk removal (#13850)
  T13844 mcall undefined errors (#13849)
* upstream/4.0.x:
  Regenerated the build
  Regenerated ext
  Cleaned not used variable
  Update change log
  typo in comment
  Pdo radicaloptions (#13862)
  Fixed #13858 - Nanobox config fails for php 7.3 (#13866)
  Remove all 'fresh' code from the DI (since its no longer needed for the dispatcher hack). (#13861)
  Update boxfile.7.2.yml (#13859)
  Refactored security tests from SecurityCest (#13864)
  Cleanup
  Again regenerating ext/
  Regenerating ext folder
  DI::get shared caching - a more comprehensive solution (#13846)
  Allow grouped config loader to determine adaptor from file extension. (#13762)
  Dispatcher handlercache (#13854)
  [#13835] - Changed Volt compiler options. (#13840)
  [#11926] Changed view engine service closures to no longer receive th… (#13839)
  Corrected typo
* upstream/4.0.x:
  [Translate] more options to csv adapter (#13877)
  Bump version
* upstream/4.0.x:
  T13886 collection (#13891)
  T11789 PSR-7/ PSR-17 (#13885)
  A little try to add @param tags to documentation
* upstream/4.0.x:
  T13893 registry collection (#13895)
  Fix: assets manager hard reference to phalcon\tag. Use DI (#13894)
@niden niden added enhancement Enhancement to the framework breaks bc Functionality that breaks Backwards Compatibility labels Mar 13, 2019
@niden niden changed the base branch from master to 4.0.x March 13, 2019 20:29
@niden niden closed this Mar 13, 2019
@niden niden deleted the 4.0.x branch March 13, 2019 20:57
@niden niden added documentation Documentation required and removed documentation Documentation required labels Apr 9, 2019
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant