[#11926] Changed view engine service closures to no longer receive th… #13839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 18, 2019 12:12
…e dependency injector as the second parameter.
Codecov Report
@@ Coverage Diff @@
## 4.0.x #13839 +/- ##
=========================================
+ Coverage 66.2% 66.2% +<.01%
=========================================
Files 451 451
Lines 89787 89792 +5
=========================================
+ Hits 59443 59447 +4
- Misses 30344 30345 +1
Continue to review full report at Codecov.
|
This comment was marked as abuse.
This comment was marked as abuse.
sergeyklay
added
breaks bc
This comment was marked as abuse.
This comment was marked as abuse.
|
I will keep this open for a day or two to allow other contributors a chance to speak up, and to take a fresh look at it later. But at the moment it seems good to me. |
CameronHall
approved these changes
Feb 24, 2019
|
Thank you @dschissler |
|
@niden Could you please add this to the docs |
niden
added
4.0
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e dependency injector as the second parameter.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Back in Phalcon 2.0 the DI was changed to bind service functions to itself. Before that it was necessary to use
use ($di)in the function. This is a minor tweak to remove the DI from being passed as the second argument in the view engine service functions. Instead use$this.NOTICE: I'm trying something different by using a different forked branch for each PR. If this change is acceptable then I'll make the change log entry to get this all of the way through. In order to avoid merge conflicts this should be done as late as possible. I hope to be able to have several of these going at once for higher throughput.