Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Registry with Collection #13893

Closed
niden opened this issue Mar 12, 2019 · 1 comment
Closed

Implement Registry with Collection #13893

niden opened this issue Mar 12, 2019 · 1 comment
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework

Comments

@niden
Copy link
Member

niden commented Mar 12, 2019 •
edited
Loading

Change Phalcon\Registry to use Phalcon\Collection to remove code duplication.

Change Phalcon\Session\Bag to also use the collection object
@niden niden added the enhancement Enhancement to the framework label Mar 12, 2019
@niden niden added the breaks bc Functionality that breaks Backwards Compatibility label Mar 12, 2019
@niden niden mentioned this issue Mar 13, 2019
Merged
4 tasks
niden added a commit that referenced this issue Mar 13, 2019
@niden
T13893 registry collection (#13895)
1e720ea 
* [4.0.x] - Added unicode flag for email filter

* [4.0.x] - Updating the ext folder

* [4.0.x] - Added Arr helper class

* Revert "[4.0.x] - Added Arr helper class"

This reverts commit f8153d3.

* Revert "[4.0.x] - Updating the ext folder"

This reverts commit 655eafe.

* [#13893] - Work on the registry extending Collection; Tests!

* [#13893] - Corrected the signature of __get

* [#13893] - Correction to the interface

* [#13893] - Case insensitivity on has and get

* [#13893] - Added more tests for case insensitivity

* [#13893] - Changed the Session\Bag component to use Collection

* [#13893] - Rework the Session\Bag tests

* [#13893] - Updated changelog

* [#13893] - Corrections after the review

* [#13893] - Removed ext/ files
@niden
Copy link
Member Author

niden commented Mar 13, 2019

Implemented

@niden niden closed this as completed Mar 13, 2019
This was referenced Mar 13, 2019
Closed
Merged
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niden