[3.0.x] Remove $di being passed in as second parameter into Volt service

[dschissler]

Phalcon 2.1 is binding the service functions to the dependency injector and so the second parameter being passed into the Volt definition is unnecessary.

This would turn the following:

$di->set('voltService', function($view, $di) {
    ...
    $volt = new Volt($view, $di);

into this:

$di->set('voltService', function($view) {
    ...
    $volt = new Volt($view, $this);

This would add consistency to the services but would have the downside of breaking existing service definitions.

[sergeyklay]

It seems to me this is mainly phalcon/docs issue

[Jurigag]

We just need to implemt both behaviours and that's it.

[sergeyklay]

Could you please explain guys what kind of problem you are discussing

[Jurigag]

For me old syntax shouldn't be removed on version 2.x. We could do it on 3.x for me. Further 2.x shouldn't have any code breaking previous 2.x versions. There should be as little as possible changes in api to update to new minor version. We should just deprecate old syntax(just trigger E_DEPRECATED if it's used) but it should work in my opinion as it is.

[Jurigag]

Where there is - we just need to use reflection, but should we ? Just if function accept two arguments - trigger deprecated and inform in which version it will be removed. We could in 2.2 maybe beacause we don't follow semver. But i think we always should inform about something before remove it, not everyone will check changelog, github or blog. Some of people will just upgrade and that's it. At least in logs they could see something.

[sergeyklay]

$di->setShared(
    'volt',
    function (\Phalcon\Mvc\ViewBaseInterface $view, \Phalcon\DiInterface $di = null) {
        /** @var \Phalcon\DiInterface $this */
        $config = $this->getShared('config');

        $volt = new Volt($view, $di ?: $this);

        $volt->setOptions(
            [
                'compiledPath'      => $config->application->view->compiledPath,
                'compiledSeparator' => $config->application->view->compiledSeparator,
                'compiledExtension' => $config->application->view->compiledExtension,
                'compileAlways'     => (bool) $config->application->debug,
            ]
        );

        return $volt;
    }
);


$di->setShared(
    'view',
    function () use () {
        /** @var \Phalcon\DiInterface $this */
        $config = $this->getShared('config');

        $view = new \Phalcon\Mvc\View();

        $engines = [
          '.volt' => $this->getShared('volt', [$view, $this]),
        ];

        $view->registerEngines($engines);
        $view->setViewsDir($config->application->view->viewsDir);

        return $view;
    }
);

[Jurigag]

It can be done in 3.* with keeping BC using reflection but there is no point in this imho.

[niden]

Closing in favor of #13855. Will revisit if the community votes for it, or in later versions.