T13886 collection #13891
Merged
T13886 collection #13891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/4.0.x: [4.0.x] - Added unicode flag for email filter
* upstream/4.0.x: Updated changelog Updated CFLAG default build param keep the actionName as set, do cache the methodName in `getActiveMethod` instead (use action mapping to cover Dispatcher `forward`ing case?) move formatter into setter give up on `camelize`, use a new approach unit tests Camel-case the action name (before call in handler) Correct pull request template Fix .editorconfig Amended .gitignore Bump version Fixed preparing release on AppVeyor Update change log Regenerated build Regenerated ext Updating the changelog
* upstream/4.0.x: Update CHANGELOG-4.0.md Updated changelog Added geSetMetaData test Modified some unit tests to use metaData Modified existing tests to work with the additional MetaData Modified Phalcon\Mvc\Model to use Phalcon\Message::setMetaData() instead of setModel() Added new MetaData variable to Phalcon\Message. Modified Phalcon\MessageInterface accordingly Corrected typo
* upstream/4.0.x: [#2182] - Updated the changelog and PR template [#2182] - Added before/after compile events for Volt [#2182] - Removed some obsolete tests; Added tests for engine/render events Updated changelog fix tests change tests fix stan Add `Dispatcher::toCamelCase()` method [#13819] - Updated the changelog [#13819] - Removing css/js optimizers from the config [#13819] - Updating ext/ [#13819] - Removed minifiers [#13819] - Marked tests as skipped
* upstream/4.0.x: Allow Config::merge to accept a basic array. (#13830)
This reverts commit f8153d3.
This reverts commit 655eafe.
* upstream/4.0.x: Install MySQL 5.7 on Travis CI [skip appveyor] (#13835)
* upstream/4.0.x: Regenerated the build Regenerated ext Cleaned not used variable Update change log typo in comment Pdo radicaloptions (#13862) Fixed #13858 - Nanobox config fails for php 7.3 (#13866) Remove all 'fresh' code from the DI (since its no longer needed for the dispatcher hack). (#13861) Update boxfile.7.2.yml (#13859) Refactored security tests from SecurityCest (#13864) Cleanup Again regenerating ext/ Regenerating ext folder DI::get shared caching - a more comprehensive solution (#13846) Allow grouped config loader to determine adaptor from file extension. (#13762) Dispatcher handlercache (#13854) [#13835] - Changed Volt compiler options. (#13840) [#11926] Changed view engine service closures to no longer receive th… (#13839) Corrected typo
* upstream/4.0.x: [Translate] more options to csv adapter (#13877) Bump version
|
cc @sergeyklay |
Codecov Report
@@ Coverage Diff @@
## 4.0.x #13891 +/- ##
========================================
Coverage ? 66.84%
========================================
Files ? 448
Lines ? 89074
Branches ? 0
========================================
Hits ? 59541
Misses ? 29533
Partials ? 0Continue to review full report at Codecov.
|
sergeyklay
previously approved these changes
Mar 12, 2019
|
@niden Can we reuse this in the Phalcon\Registry ? |
|
@sergeyklay I need to check the Registry but yeah I believe so |
|
It looks to me like a similar but better implementation of Registry |
niden
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Added
Phalcon\Collection, offering a collection object for various parts of the framework such as handling arrays, superglobals etc.Thanks