fix(transformer/class-properties): create temp var for class where required

[overlookmotel]

Fix class properties transform to create a temp var for class when it's required.

Input:

class C {
  static getSelf = () => this;
}
const C2 = C;
C = 123;
assert(C2.getSelf() === C);

Output:

var _C;
class C {}
_C = C;
_defineProperty(C, "getSelf", () => _C);
const C2 = C;
C = 123;
assert(C2.getSelf() === C);

Previously, temp var wasn't used so code was _defineProperty(C, "getSelf", () => C);. C is altered later by C = 123, so C2.getSelf() returned 123, instead of reference to the class.

The logic around when a temp var is required and when it's not, and when/where it's referenced is ridiculously complicated. So add some debug assert mechanisms to double-check the logic.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• refactor(transformer/class-properties): remove pointless method #7592
• fix(transformer/class-properties): create temp var for class where required #7516 👈 (View in Graphite)
• refactor(transformer/class-properties): PrivatePropsStack type #7589
• docs(transformer/class-properties): add missing docs #7588
• refactor(transformer/class-properties): move creating temp var out of main loop #7587
• refactor(transformer/class-properties): exit transform_class faster if nothing to do #7586
• refactor(transformer/class-properties): ResolvedPrivateProp type #7532
• refactor(transformer/class-properties): shortcut_static_class take SymbolId #7531
• refactor(transformer/class-properties): rename class_binding #7533
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7516 will not alter performance

_{Comparing 11-27-fix_transformer_class-properties_create_temp_var_for_class_where_required (0eadd9f) with 12-02-refactor_transformer_class-properties_privatepropsstack_type (a07f278)}

Summary

✅ 30 untouched benchmarks

[graphite-app]

Merge activity

• Dec 3, 2:44 AM EST: A user added this pull request to the Graphite merge queue.
• Dec 3, 3:37 AM EST: A user merged this pull request with the Graphite merge queue.