Skip to content

refactor(transformer/class-properties): PrivatePropsStack type#7589

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-02-refactor_transformer_class-properties_privatepropsstack_type
Dec 3, 2024
Merged

refactor(transformer/class-properties): PrivatePropsStack type#7589
graphite-app[bot] merged 1 commit intomainfrom
12-02-refactor_transformer_class-properties_privatepropsstack_type

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 2, 2024

Pure refactor. Move all logic and types related to storing details of what private properties classes have into a separate file private_props.rs. Introduce a type PrivatePropsStack to represent the stack of classes.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 2, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #7589 will not alter performance

Comparing 12-02-refactor_transformer_class-properties_privatepropsstack_type (a07f278) with 12-02-docs_transformer_class-properties_add_missing_docs (f481d25)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 12-02-docs_transformer_class-properties_add_missing_docs branch from cafb613 to f481d25 Compare December 3, 2024 02:00
@overlookmotel overlookmotel force-pushed the 12-02-refactor_transformer_class-properties_privatepropsstack_type branch from 3547117 to 1a33bd2 Compare December 3, 2024 02:00
@overlookmotel overlookmotel marked this pull request as ready for review December 3, 2024 02:27
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 3, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 3, 2024

Merge activity

Pure refactor. Move all logic and types related to storing details of what private properties classes have into a separate file `private_props.rs`. Introduce a type `PrivatePropsStack` to represent the stack of classes.
@Dunqing Dunqing force-pushed the 12-02-docs_transformer_class-properties_add_missing_docs branch from f481d25 to 370d4b9 Compare December 3, 2024 07:49
@Dunqing Dunqing force-pushed the 12-02-refactor_transformer_class-properties_privatepropsstack_type branch from 1a33bd2 to a07f278 Compare December 3, 2024 07:49
Base automatically changed from 12-02-docs_transformer_class-properties_add_missing_docs to main December 3, 2024 08:28
@graphite-app graphite-app bot merged commit a07f278 into main Dec 3, 2024
@graphite-app graphite-app bot deleted the 12-02-refactor_transformer_class-properties_privatepropsstack_type branch December 3, 2024 08:32
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant