fix(transformer/class-properties): replace references to class name with temp var in static prop initializers#7610
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 3, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
Dunqing
approved these changes
Dec 3, 2024
Member
Merge activity
|
CodSpeed Performance ReportMerging #7610 will not alter performanceComparing Summary
|
…ith temp var in static prop initializers (#7610) Similar to #7516. Fix class properties transform to replace references to class name in static prop initializers with temp var. Input: ```js class C { static getSelf = () => C; } const C2 = C; C = 123; assert(C2.getSelf() === C); ``` Output: ```js var _C; class C {} _C = C; _defineProperty(C, "getSelf", () => _C); const C2 = C; C = 123; assert(C2.getSelf() === C); ``` Previously, temp var wasn't used so code was `_defineProperty(C, "getSelf", () => C);`. `C` is altered later by `C = 123`, so `C2.getSelf()` returned `123`, instead of reference to the class.
34acef5 to
7d1c12e
Compare
a15ca31 to
eb825ed
Compare
Base automatically changed from
12-03-refactor_transformer_class-properties_rename_misleadingly-named_method
to
main
December 3, 2024 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Similar to #7516. Fix class properties transform to replace references to class name in static prop initializers with temp var.
Input:
Output:
Previously, temp var wasn't used so code was
_defineProperty(C, "getSelf", () => C);.Cis altered later byC = 123, soC2.getSelf()returned123, instead of reference to the class.