Skip to content

refactor(transformer/class-properties): remove pointless method#7592

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-03-refactor_transformer_class-properties_remove_pointless_method
Dec 3, 2024
Merged

refactor(transformer/class-properties): remove pointless method#7592
graphite-app[bot] merged 1 commit intomainfrom
12-03-refactor_transformer_class-properties_remove_pointless_method

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 3, 2024

#7516 removed the need for a special method to handle export default class {}. Delete it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 3, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7592 will not alter performance

Comparing 12-03-refactor_transformer_class-properties_remove_pointless_method (802233d) with 11-27-fix_transformer_class-properties_create_temp_var_for_class_where_required (0eadd9f)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review December 3, 2024 02:38
@overlookmotel
Copy link
Member Author

overlookmotel commented Dec 3, 2024

@Dunqing Getting this working has had me tearing my hair out for days. I suggest not giving it a full review - I'm as sure as I can be that it's correct now, and it'll likely only have you tearing your hair out too!

But please do take a look at the changes to transform_private_field_expression_impl in #7532 and #7516, as I've had to change the APIs related to private fields, which will affect your work on this?.#prop. I don't think it'll make a dramatic difference, but your PR will need a few tweaks to align with the changes here. Happy to help if it causes you trouble.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 3, 2024
Copy link
Member

Dunqing commented Dec 3, 2024

Merge activity

  • Dec 3, 2:44 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 2:44 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 3, 3:44 AM EST: A user merged this pull request with the Graphite merge queue.

#7516 removed the need for a special method to handle `export default class {}`. Delete it.
@Dunqing Dunqing force-pushed the 11-27-fix_transformer_class-properties_create_temp_var_for_class_where_required branch from 66dc1b0 to 0eadd9f Compare December 3, 2024 07:50
@Dunqing Dunqing force-pushed the 12-03-refactor_transformer_class-properties_remove_pointless_method branch from 8d66279 to 802233d Compare December 3, 2024 07:50
Base automatically changed from 11-27-fix_transformer_class-properties_create_temp_var_for_class_where_required to main December 3, 2024 08:37
@graphite-app graphite-app bot merged commit 802233d into main Dec 3, 2024
@graphite-app graphite-app bot deleted the 12-03-refactor_transformer_class-properties_remove_pointless_method branch December 3, 2024 08:44
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants