refactor(transformer/class-properties): ResolvedPrivateProp type#7532
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 3, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This was referenced Nov 28, 2024
CodSpeed Performance ReportMerging #7532 will not alter performanceComparing Summary
|
6d505f7 to
c855c2d
Compare
d77528d to
2ea88cf
Compare
2ea88cf to
6b7c4f5
Compare
c855c2d to
977a5fb
Compare
2509562 to
2728d4b
Compare
977a5fb to
08170e2
Compare
2728d4b to
0282aa3
Compare
08170e2 to
a7e8ea6
Compare
0282aa3 to
b9200ad
Compare
This was referenced Dec 2, 2024
a7e8ea6 to
2d1525e
Compare
b9200ad to
89d67f6
Compare
Dunqing
approved these changes
Dec 3, 2024
Contributor
Merge activity
|
…7532) Pure refactor. `lookup_private_property` returns a tuple of 3 items, and future changes will make that 4. That's silly. Create a type `ResolvedPrivateProp` for it to return, so the various parts can have descriptive names.
2d1525e to
367b6c8
Compare
89d67f6 to
dccff38
Compare
Base automatically changed from
11-28-refactor_transformer_class-properties_shortcut_static_class_take_symbolid_
to
main
December 3, 2024 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pure refactor.
lookup_private_propertyreturns a tuple of 3 items, and future changes will make that 4. That's silly. Create a typeResolvedPrivatePropfor it to return, so the various parts can have descriptive names.