Skip to content

fix(oxfmt): ensure stdin blocking mode is set for non-TTY environments#20289

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/03-12-fix_oxfmt_ensure_stdin_blocking_mode_is_set_for_non-tty_environments
Mar 12, 2026
Merged

fix(oxfmt): ensure stdin blocking mode is set for non-TTY environments#20289
graphite-app[bot] merged 1 commit intomainfrom
c/03-12-fix_oxfmt_ensure_stdin_blocking_mode_is_set_for_non-tty_environments

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Mar 12, 2026

No description provided.

@camc314 camc314 marked this pull request as ready for review March 12, 2026 13:43
Copilot AI review requested due to automatic review settings March 12, 2026 13:43
Copy link
Contributor Author

camc314 commented Mar 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug labels Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures oxfmt’s NAPI-based JS CLI avoids Rust WouldBlock/non-blocking stdio issues in non-TTY (piped) environments by applying the same blocking-mode workaround to stdin as well as stdout.

Changes:

  • Set process.stdin’s internal handle to blocking mode when stdin is not a TTY (mirroring the existing stdout workaround).

You can also share your feedback on Copilot code review. Take the survey.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
Copy link
Contributor Author

camc314 commented Mar 12, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/03-12-fix_oxfmt_ensure_stdin_blocking_mode_is_set_for_non-tty_environments branch from a4ce1fe to 96f761f Compare March 12, 2026 13:56
@camc314 camc314 self-assigned this Mar 12, 2026
@graphite-app graphite-app bot merged commit 96f761f into main Mar 12, 2026
19 checks passed
@graphite-app graphite-app bot deleted the c/03-12-fix_oxfmt_ensure_stdin_blocking_mode_is_set_for_non-tty_environments branch March 12, 2026 14:07
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
graphite-app bot pushed a commit that referenced this pull request Mar 12, 2026
# Oxlint
### 🐛 Bug Fixes

- 6b46ce8 oxlint: Ignore inherited root-only options in nested configs (#20291) (camc314)
- bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur)
- f26e6ab linter: Make `generate-plugin-eslint` script work on windows (#20246) (camc314)

### 📚 Documentation

- e4aa5b5 parser/napi, linter/plugins: Add JSDoc comments to raw transfer constants (#20286) (overlookmotel)
- f339f10 linter/plugins: Promote JS plugins to alpha status (#20281) (overlookmotel)
# Oxfmt
### 🐛 Bug Fixes

- 96f761f oxfmt: Ensure stdin blocking mode is set for non-TTY environments (#20289) (camc314)
- bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur)
graphite-app bot pushed a commit that referenced this pull request Mar 13, 2026
graphite-app bot pushed a commit that referenced this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formatter: Format on save via VSCode Extension hangs as of v0.38.0 of oxfmt

2 participants