fix(oxlint): ignore inherited root-only options in nested configs#20291
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
Adjusts oxlint’s nested config loading so that root-only options.* are only validated when they are explicitly set in the nested config file itself (not inherited via extends), matching how these options are treated at runtime (root-config-only).
Changes:
- Move nested root-only option validation to run before
extendsmerging by checkingconfig.optionsdirectly. - Continue rejecting root-only options when set directly in nested configs, while allowing them when coming from extended configs.
- Update/add tests to cover the new “allowed via extends” behavior for JSON and TS configs.
You can also share your feedback on Copilot code review. Take the survey.
Merge activity
|
7fb1578 to
6b46ce8
Compare
# Oxlint ### 🐛 Bug Fixes - 6b46ce8 oxlint: Ignore inherited root-only options in nested configs (#20291) (camc314) - bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur) - f26e6ab linter: Make `generate-plugin-eslint` script work on windows (#20246) (camc314) ### 📚 Documentation - e4aa5b5 parser/napi, linter/plugins: Add JSDoc comments to raw transfer constants (#20286) (overlookmotel) - f339f10 linter/plugins: Promote JS plugins to alpha status (#20281) (overlookmotel) # Oxfmt ### 🐛 Bug Fixes - 96f761f oxfmt: Ensure stdin blocking mode is set for non-TTY environments (#20289) (camc314) - bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur)

fixes #19932