Skip to content

fix(oxlint): ignore inherited root-only options in nested configs#20291

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/03-12-fix_oxlint_ignore_inherited_root-only_options_in_nested_configs
Mar 12, 2026
Merged

fix(oxlint): ignore inherited root-only options in nested configs#20291
graphite-app[bot] merged 1 commit intomainfrom
c/03-12-fix_oxlint_ignore_inherited_root-only_options_in_nested_configs

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Mar 12, 2026

fixes #19932

Copy link
Contributor Author

camc314 commented Mar 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Mar 12, 2026
@camc314 camc314 marked this pull request as ready for review March 12, 2026 14:16
Copilot AI review requested due to automatic review settings March 12, 2026 14:16
@camc314 camc314 self-assigned this Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts oxlint’s nested config loading so that root-only options.* are only validated when they are explicitly set in the nested config file itself (not inherited via extends), matching how these options are treated at runtime (root-config-only).

Changes:

  • Move nested root-only option validation to run before extends merging by checking config.options directly.
  • Continue rejecting root-only options when set directly in nested configs, while allowing them when coming from extended configs.
  • Update/add tests to cover the new “allowed via extends” behavior for JSON and TS configs.

You can also share your feedback on Copilot code review. Take the survey.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
Copy link
Contributor Author

camc314 commented Mar 12, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/03-12-fix_oxlint_ignore_inherited_root-only_options_in_nested_configs branch from 7fb1578 to 6b46ce8 Compare March 12, 2026 14:28
@graphite-app graphite-app bot merged commit 6b46ce8 into main Mar 12, 2026
19 checks passed
@graphite-app graphite-app bot deleted the c/03-12-fix_oxlint_ignore_inherited_root-only_options_in_nested_configs branch March 12, 2026 14:39
graphite-app bot pushed a commit that referenced this pull request Mar 12, 2026
# Oxlint
### 🐛 Bug Fixes

- 6b46ce8 oxlint: Ignore inherited root-only options in nested configs (#20291) (camc314)
- bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur)
- f26e6ab linter: Make `generate-plugin-eslint` script work on windows (#20246) (camc314)

### 📚 Documentation

- e4aa5b5 parser/napi, linter/plugins: Add JSDoc comments to raw transfer constants (#20286) (overlookmotel)
- f339f10 linter/plugins: Promote JS plugins to alpha status (#20281) (overlookmotel)
# Oxfmt
### 🐛 Bug Fixes

- 96f761f oxfmt: Ensure stdin blocking mode is set for non-TTY environments (#20289) (camc314)
- bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: options.typeAware linter error when using nested oxlint.config.ts in monorepo

2 participants