fix(linter): make generate-plugin-eslint script work on windows#20246
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 12, 2026
Merged
fix(linter): make generate-plugin-eslint script work on windows#20246graphite-app[bot] merged 1 commit intomainfrom
generate-plugin-eslint script work on windows#20246graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
commented
Mar 11, 2026
camc314
changed the title
generate-plugin-eslint script work on windows
camc314
force-pushed
the
c/03-11-fix
branch
4 times, most recently
from
86f9d9e to
f33e500
Compare
Contributor
Author
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the generate-plugin-eslint build script to run the oxfmt formatting step in a way that works on Windows (where invoking pnpm via execFileSync can fail due to the .cmd wrapper).
Changes:
- Replace
execFileSync("pnpm", [...])with a shell-basedexecSync("pnpm exec ...")invocation to improve Windows compatibility.
You can also share your feedback on Copilot code review. Take the survey.
graphite-app
bot
force-pushed
the
c/03-11-fix
branch
from
ad77311 to
f26e6ab
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
# Oxlint ### 🐛 Bug Fixes - 6b46ce8 oxlint: Ignore inherited root-only options in nested configs (#20291) (camc314) - bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur) - f26e6ab linter: Make `generate-plugin-eslint` script work on windows (#20246) (camc314) ### 📚 Documentation - e4aa5b5 parser/napi, linter/plugins: Add JSDoc comments to raw transfer constants (#20286) (overlookmotel) - f339f10 linter/plugins: Promote JS plugins to alpha status (#20281) (overlookmotel) # Oxfmt ### 🐛 Bug Fixes - 96f761f oxfmt: Ensure stdin blocking mode is set for non-TTY environments (#20289) (camc314) - bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.