Skip to content

chore(oxfmt): Add comment for setBlocking(true)#20323

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-13-chore_oxfmt_add_comment_for_setblocking_true_
Mar 13, 2026
Merged

chore(oxfmt): Add comment for setBlocking(true)#20323
graphite-app[bot] merged 1 commit intomainfrom
03-13-chore_oxfmt_add_comment_for_setblocking_true_

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Mar 13, 2026

Follow up #20289 , just adding comments.

Copilot AI review requested due to automatic review settings March 13, 2026 04:27
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the inline documentation around why the oxfmt JS CLI forces stdin/stdout into blocking mode when running under non‑TTY (piped) I/O, clarifying separate failure modes for output vs input and linking to relevant upstream issues.

Changes:

  • Refines the existing explanation of Node.js non‑TTY stdio being non‑blocking and how that surfaces as Rust WouldBlock/EAGAIN errors.
  • Splits the rationale into distinct stdout and stdin sections with concrete repro contexts (--stdin-filepath and --lsp) and issue links.

You can also share your feedback on Copilot code review. Take the survey.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Mar 13, 2026
Copy link
Member Author

leaysgur commented Mar 13, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 03-13-chore_oxfmt_add_comment_for_setblocking_true_ branch from b2c9e43 to e9e7442 Compare March 13, 2026 04:39
graphite-app bot pushed a commit that referenced this pull request Mar 13, 2026
@graphite-app graphite-app bot force-pushed the 03-13-chore_oxfmt_add_comment_for_setblocking_true_ branch from e9e7442 to 4ce33e8 Compare March 13, 2026 04:45
@graphite-app graphite-app bot merged commit 4ce33e8 into main Mar 13, 2026
19 checks passed
@graphite-app graphite-app bot deleted the 03-13-chore_oxfmt_add_comment_for_setblocking_true_ branch March 13, 2026 04:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants