chore(oxfmt): Add comment for setBlocking(true)#20323
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR improves the inline documentation around why the oxfmt JS CLI forces stdin/stdout into blocking mode when running under non‑TTY (piped) I/O, clarifying separate failure modes for output vs input and linking to relevant upstream issues.
Changes:
- Refines the existing explanation of Node.js non‑TTY stdio being non‑blocking and how that surfaces as Rust
WouldBlock/EAGAINerrors. - Splits the rationale into distinct
stdoutandstdinsections with concrete repro contexts (--stdin-filepathand--lsp) and issue links.
You can also share your feedback on Copilot code review. Take the survey.
Merge activity
|
b2c9e43 to
e9e7442
Compare
Follow up #20289 , just adding comments.
Follow up #20289 , just adding comments.
e9e7442 to
4ce33e8
Compare

Follow up #20289 , just adding comments.