docs(parser/napi, linter/plugins): add JSDoc comments to raw transfer constants#20286
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 12, 2026
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-docs
Contributor
There was a problem hiding this comment.
Pull request overview
Adds JSDoc documentation for the raw-transfer buffer layout constants so consumers of the generated constants.js / constants.ts can more easily understand sizes/alignments and field offsets.
Changes:
- Add JSDoc blocks to the raw-transfer constants template in
raw_transfer.rs. - Regenerate
napi/parserJS constants output with the new comments. - Regenerate
apps/oxlintTS constants output with the new comments.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tasks/ast_tools/src/generators/raw_transfer.rs | Updates the generator template to emit JSDoc for each raw-transfer constant. |
| napi/parser/src-js/generated/constants.js | Regenerated output containing the new JSDoc comments for buffer/offset constants. |
| apps/oxlint/src-js/generated/constants.ts | Regenerated output containing the same JSDoc comments for TS consumers. |
overlookmotel
force-pushed
the
om/03-12-docs_parser_napi_linter_plugins_add_jsdoc_comments_to_raw_transfer_constants
branch
from
8b941c0 to
fbe3a9d
Compare
Member
Author
Merge activity
|
… constants (#20286) Comments-only change. Add JSDoc comments to the constants related to raw transfer in generated files `constants.js` / `constants.ts`. There are now a lot of constants, and it wasn't clear what they all mean.
graphite-app
bot
force-pushed
the
om/03-12-docs_parser_napi_linter_plugins_add_jsdoc_comments_to_raw_transfer_constants
branch
from
fbe3a9d to
e4aa5b5
Compare
graphite-app
bot
deleted the
om/03-12-docs_parser_napi_linter_plugins_add_jsdoc_comments_to_raw_transfer_constants
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
# Oxlint ### 🐛 Bug Fixes - 6b46ce8 oxlint: Ignore inherited root-only options in nested configs (#20291) (camc314) - bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur) - f26e6ab linter: Make `generate-plugin-eslint` script work on windows (#20246) (camc314) ### 📚 Documentation - e4aa5b5 parser/napi, linter/plugins: Add JSDoc comments to raw transfer constants (#20286) (overlookmotel) - f339f10 linter/plugins: Promote JS plugins to alpha status (#20281) (overlookmotel) # Oxfmt ### 🐛 Bug Fixes - 96f761f oxfmt: Ensure stdin blocking mode is set for non-TTY environments (#20289) (camc314) - bc20217 oxlint,oxfmt: Omit useless `| null` for `Option<T>` field from schema (#20273) (leaysgur)
Boshen
added a commit
that referenced
this pull request
Mar 14, 2026
### 🚀 Features - e7163b6 ecmascript: Add known-globals to side-effect-free property reads (#20212) (Dunqing) - 139ab68 ecmascript: Add `property_write_side_effects` to `MayHaveSideEffectsContext` (#20217) (Dunqing) ### 🐛 Bug Fixes - 78c264a parser: Fix conditional expressions with arrow-function alternates in TS (#20356) (camc314) - 5c97b14 minifier: Recognize object spread of object literals as side-effect-free (#20299) (Boshen) - 1ff5c1d transformer/typescript: Rewrite extensions in dynamic `import()` expressions (#20121) (Sverre Johansen) - 1c07b3b diagnostics: Handle `WouldBlock` in stdout writes to prevent panic (#20295) (Boshen) - ade14d4 ecmascript: Enhance side-effect detection for classes, TypedArrays, computed members, and spread (#20213) (Dunqing) ### ⚡ Performance - 5474d0a semantic: V8-style walk-up reference resolution (#20292) (Boshen) ### 📚 Documentation - e4aa5b5 parser/napi, linter/plugins: Add JSDoc comments to raw transfer constants (#20286) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments-only change. Add JSDoc comments to the constants related to raw transfer in generated files
constants.js/constants.ts. There are now a lot of constants, and it wasn't clear what they all mean.