test(linter/plugins): simplify tester script#18343
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
github-actions
bot
added
A-linter
This was referenced Jan 21, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the tester script by removing the unnecessary config parameter throughout the test execution flow. The conformance test version of RuleTester already enables eslintCompat via a registered hook, making the manual configuration redundant.
Changes:
- Removed unused
configvariable declarations and parameter from test execution functions - Simplified
runBothandrunOnefunction signatures by removing the obsoleteconfigparameter - Cleaned up the RuleTester instantiation to use the default constructor
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Simplify tester script. `config` is not needed any more. The conformance tests' version of `RuleTester` already enables `eslintCompat` option.
graphite-app
bot
force-pushed
the
om/01-21-test_linter_plugins_improve_internal_types
branch
from
f0e9bd4 to
4497f3d
Compare
graphite-app
bot
force-pushed
the
om/01-21-test_linter_plugins_simplify_tester_script
branch
from
687a0e8 to
7db6753
Compare
Base automatically changed from
om/01-21-test_linter_plugins_improve_internal_types
to
main
January 21, 2026 12:25
graphite-app
bot
deleted the
om/01-21-test_linter_plugins_simplify_tester_script
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify tester script.
configis not needed any more. The conformance tests' version ofRuleTesteralready enableseslintCompatoption.