test(linter/plugins): skip conformance tests that cannot expect to pass#18345
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 21, 2026
Conversation
github-actions
bot
added
A-linter
This was referenced Jan 21, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves conformance test handling by skipping tests that cannot pass due to parser limitations. The changes identify and skip tests requiring ES3/ES5 parsing support, tests with unrecoverable syntax errors, and tests affected by TypeScript parser tokenization issues.
Changes:
- Added logic to skip 14 conformance tests that require unsupported parsing capabilities (ES3/ES5 semantics)
- Updated snapshot documentation to reflect 4 rules moving from "partially passing" to "fully passing" status
- Reduced total failing tests from 20 to 6
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/conformance/src/capture.ts | Added shouldSkipTest logic to skip ES3/ES5 tests, parsing errors, and TypeScript tokenization issues; imported LanguageOptionsInternal type |
| apps/oxlint/conformance/snapshot.md | Updated test statistics and removed documentation for 14 now-skipped test failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
om/01-21-test_linter_plugins_conformance_tests_include_config_in_snapshot
branch
from
b07387c to
a277087
Compare
overlookmotel
force-pushed
the
om/01-21-test_linter_plugins_skip_conformance_tests_that_cannot_expect_to_pass
branch
from
2cbdd2c to
82efa52
Compare
Member
Author
Merge activity
|
…ss (#18345) A handful of conformance tests are never going to be possible to pass due to requiring ability to e.g. parse as ES3. This isn't important for actual linter plugins, so just skip these tests. Only 6 failing tests remaining!
graphite-app
bot
force-pushed
the
om/01-21-test_linter_plugins_conformance_tests_include_config_in_snapshot
branch
from
a277087 to
8a1232e
Compare
graphite-app
bot
force-pushed
the
om/01-21-test_linter_plugins_skip_conformance_tests_that_cannot_expect_to_pass
branch
from
82efa52 to
e51857f
Compare
Base automatically changed from
om/01-21-test_linter_plugins_conformance_tests_include_config_in_snapshot
to
main
January 21, 2026 12:26
graphite-app
bot
deleted the
om/01-21-test_linter_plugins_skip_conformance_tests_that_cannot_expect_to_pass
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
…`s (#18368) Espree (ESLint's parser) has the surprising behavior that it produces `Keyword` tokens for identifiers called `let`, `static`, and `yield`. Fix our tokens to match Espree. #18345 skipped 4 conformance tests for `no-extra-parens` rule. These tests now don't need to be skipped and they pass. Related: typescript-eslint/typescript-eslint#11989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of conformance tests are never going to be possible to pass due to requiring ability to e.g. parse as ES3. This isn't important for actual linter plugins, so just skip these tests.
Only 6 failing tests remaining!