test(linter/plugins): conformance tests include config in snapshot#18344
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 21, 2026
Conversation
github-actions
bot
added
A-linter
This was referenced Jan 21, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how test cases are captured in the conformance test runner. The previous approach wrapped test execution functions to attach test case data to errors, which was hacky. The new approach captures test case data directly in the modifyTestCase hook before tests run, resulting in cleaner code and more complete snapshot details.
Changes:
- Removed the
wrapRunTestCaseFunctionwrapper and related code fromrule_tester.ts - Added
setCurrentTestfunction to capture test cases in themodifyTestCasehook - Refactored error handling and test skip logic in the
itfunction for better organization
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/src-js/package/rule_tester.ts | Removed 32 lines of wrapper code that attached test cases to errors |
| apps/oxlint/conformance/src/rule_tester.ts | Added test case capture via setCurrentTest() in the modifyTestCase hook |
| apps/oxlint/conformance/src/capture.ts | Added setCurrentTest function, refactored error handling logic, and extracted shouldSkipTest helper |
| apps/oxlint/conformance/snapshot.md | Updated snapshots to include config properties (ecmaVersion, sourceType, parserOptions) from RuleTester constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
om/01-21-test_linter_plugins_conformance_tests_include_config_in_snapshot
branch
from
b07387c to
a277087
Compare
Contributor
Merge activity
|
…18344) Change how test cases are captured by the conformance test runner. * Remove the hacky `wrapRunTestCaseFunction` from `RuleTester`. * Instead, capture the test case object in the `modifyTestCase` hook. This has 2 effects: 1. Conformance tests only make one patch to `RuleTester` (`modifyTestCase` hook), rather than two patches. This simplifies things. 2. The test case details in conformance snapshots include properties added to the test case from config (options passed to `new RuleTester()`). This makes the details in snapshot a complete picture for each test case.
graphite-app
bot
force-pushed
the
om/01-21-test_linter_plugins_simplify_tester_script
branch
from
687a0e8 to
7db6753
Compare
graphite-app
bot
force-pushed
the
om/01-21-test_linter_plugins_conformance_tests_include_config_in_snapshot
branch
from
a277087 to
8a1232e
Compare
Base automatically changed from
om/01-21-test_linter_plugins_simplify_tester_script
to
main
January 21, 2026 12:26
graphite-app
bot
deleted the
om/01-21-test_linter_plugins_conformance_tests_include_config_in_snapshot
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how test cases are captured by the conformance test runner.
wrapRunTestCaseFunctionfromRuleTester.modifyTestCasehook.This has 2 effects:
RuleTester(modifyTestCasehook), rather than two patches. This simplifies things.new RuleTester()). This makes the details in snapshot a complete picture for each test case.