Skip to content

test(linter/plugins): simplify tester script #18343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 21, 2026
Merged

test(linter/plugins): simplify tester script #18343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions apps/oxlint/conformance/tester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,6 @@ const testCase: TestCaseWithoutCode = {
]
};

const config = {};

------------- Script setup ends -------------

## 3. Run the test
Expand Down Expand Up @@ -164,20 +162,17 @@ const testCase: TestCaseWithoutCode = {
],
};

const config = {};

// -----------------------------------------------------------------------------
// Run test case with both ESLint and Oxlint
// -----------------------------------------------------------------------------

runBoth(ruleName, isInvalid, code, testCase, config);
runBoth(ruleName, isInvalid, code, testCase);

function runBoth(
ruleName: string,
isInvalid: boolean,
code: string,
testCase: TestCaseWithoutCode,
config?: Record<string, unknown> | null,
) {
testCase = { code, ...testCase };

Expand All @@ -194,24 +189,17 @@ function runBoth(
console.log("--------------------");
console.log("ESLint");
console.log("--------------------");
runOne(ESLintRuleTester, rule, valid, invalid, config);
runOne(ESLintRuleTester, rule, valid, invalid);

console.log("\n--------------------");
console.log("Oxlint");
console.log("--------------------");
config = { ...config, eslintCompat: true };
runOne(OxlintRuleTester, rule, valid, invalid, config);
runOne(OxlintRuleTester, rule, valid, invalid);
}

function runOne(
RuleTester: any,
rule: Rule,
valid: ValidTestCase[],
invalid: InvalidTestCase[],
config?: Record<string, unknown> | null,
) {
function runOne(RuleTester: any, rule: Rule, valid: ValidTestCase[], invalid: InvalidTestCase[]) {
try {
const tester = new RuleTester(config);
const tester = new RuleTester();
tester.run("my-rule", rule, { valid, invalid });
console.log("No errors");
} catch (err) {
Expand Down
Loading