test(linter/plugins): improve internal types#18342
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors internal type definitions to improve type safety and reduce code duplication in the linter plugin testing infrastructure. It introduces a ParserOptionsInternal type that bridges between LanguageOptionsInternal and EcmaFeaturesInternal, and consolidates duplicate type definitions across conformance test files.
Changes:
- Added
ParserOptionsInternaltype to properly extendParserOptionswithEcmaFeaturesInternal - Exported and extended
LanguageOptionsInternalto useParserOptionsInternal - Removed duplicate type definitions in conformance tests by reusing the exported types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/package/rule_tester.ts | Added ParserOptionsInternal interface, exported LanguageOptionsInternal, and removed unnecessary type casting |
| apps/oxlint/conformance/tester.ts | Replaced local type definitions with imported LanguageOptionsInternal and renamed ExtraCaseProps to TestCaseExtension |
| apps/oxlint/conformance/src/rule_tester.ts | Removed duplicate LanguageOptionsInternal definition and imported/re-exported from main rule tester |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Pure refactor. 1. Add a `ParserOptionsInternal` type which bridges between `LanguageOptionsInternal` and `EcmaFeaturesInternal`. 2. Reuse `LanguageOptionsInternal` type in conformance tests, rather than redefining the same type again.
graphite-app
bot
force-pushed
the
om/01-21-fix_linter_plugins_allow_line_number_passed_to_report_to_be_1_over_line_count
branch
from
807618a to
a3914fd
Compare
graphite-app
bot
force-pushed
the
om/01-21-test_linter_plugins_improve_internal_types
branch
from
f0e9bd4 to
4497f3d
Compare
Base automatically changed from
om/01-21-fix_linter_plugins_allow_line_number_passed_to_report_to_be_1_over_line_count
to
main
January 21, 2026 12:24
graphite-app
bot
deleted the
om/01-21-test_linter_plugins_improve_internal_types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor.
ParserOptionsInternaltype which bridges betweenLanguageOptionsInternalandEcmaFeaturesInternal.LanguageOptionsInternaltype in conformance tests, rather than redefining the same type again.