refactor(linter): reduce repeat code in JS plugin linting

[overlookmotel]

Follow-on after #17013. Refactor.

Reduce repeated code by getting a &mut Program out of the ContextHost at the start of the process, instead of in 2 places later on.

This also enables an optimization in next PR.

[overlookmotel]

• docs(linter): fix typo in doc comment #17091
• test(linter/plugins): enable import plugin on one test fixture #17089
• perf(linter): avoid cloning source text when cloning AST into fixed-size allocator #17088
• refactor(linter): reduce repeat code in JS plugin linting #17087 👈 (View in Graphite)
• refactor(linter): reduce repeated logic in JS plugin linting #17086
• refactor(allocator): simplify return type of FixedSizeAllocatorPool::create_new_allocator #17080
• perf(allocator): reduce time Mutex lock is held in FixedSizeAllocatorPool::get #17079
• refactor(allocator): move nested function out of FixedSizeAllocatorPool::get #17078
• refactor(allocator): remove AllocError from fixed size allocator #17077
• fix(linter): OOM problems with custom plugins #17013
• feat(allocator): add cap to FixedSizeAllocatorPool and block when exhausted #17023
• refactor(allocator/fixed-size): return Result from allocation instead of panicking #17022
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17087 will not alter performance

_{Comparing om/12-18-refactor_linter_reduce_repeat_code_in_js_plugin_linting (fee8a45) with main (fb9e193)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on om/12-18-refactor_linter_reduce_repeated_logic_in_js_plugin_linting (9a293a2) during the generation of this report, so main (fb9e193) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR refactors the JS plugin linting code to reduce duplication by extracting the &mut Program from ContextHost once at the beginning of run_external_rules, rather than performing this extraction in two separate code paths. This simplification makes the code more maintainable and sets up for future optimizations.

Key changes:

• Moved the Semantic extraction and Program pointer creation to happen before branching on js_allocator_pool
• Updated clone_into_fixed_size_allocator_and_run_external_rules to accept an already-extracted &Program instead of extracting it internally
• Swapped parameter order in convert_and_call_external_linter to place program before allocator for consistency

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Dec 18, 11:39 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Dec 18, 11:55 PM UTC: Merged by the Graphite merge queue.