refactor(allocator): move nested function out of FixedSizeAllocatorPool::get

[overlookmotel]

Follow-on after #17023. Pure refactor.

Move code out of FixedSizeAllocatorPool::get, to make it easier to read. Also add comments.

[overlookmotel]

• docs(linter): fix typo in doc comment #17091
• test(linter/plugins): enable import plugin on one test fixture #17089
• perf(linter): avoid cloning source text when cloning AST into fixed-size allocator #17088
• refactor(linter): reduce repeat code in JS plugin linting #17087
• refactor(linter): reduce repeated logic in JS plugin linting #17086
• refactor(allocator): simplify return type of FixedSizeAllocatorPool::create_new_allocator #17080
• perf(allocator): reduce time Mutex lock is held in FixedSizeAllocatorPool::get #17079
• refactor(allocator): move nested function out of FixedSizeAllocatorPool::get #17078 👈 (View in Graphite)
• refactor(allocator): remove AllocError from fixed size allocator #17077
• fix(linter): OOM problems with custom plugins #17013
• feat(allocator): add cap to FixedSizeAllocatorPool and block when exhausted #17023
• refactor(allocator/fixed-size): return Result from allocation instead of panicking #17022
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[camc314]

lol, claude suggested this change while I was working on it, and I deliberately didn't do it because it felt like I was mixing the two concerns of the pool and the fixed size allocator.

Iirc, it's also unsafe to call this function on a fixed size allocator if you didn't get it out of the pool?

[Copilot]

Pull request overview

This PR refactors the FixedSizeAllocatorPool::get method by extracting a nested function into a proper method on FixedSizeAllocator. The change improves code readability without altering any logic.

• Moved nested into_allocator function to FixedSizeAllocator::into_inner method
• Added explanatory comments to the get method flow
• Added #[inline] attribute to optimize the no-op method

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17078 will not alter performance

_{Comparing om/12-18-refactor_allocator_move_nested_function_out_of_fixedsizeallocatorpool_get_ (348c622) with om/12-18-refactor_allocator_remove_allocerror_from_fixed_size_allocator (024ab0a)¹}

Summary

✅ 42 untouched
⏩ 3 skipped²

Footnotes

1. No successful run was found on om/12-18-refactor_allocator_remove_allocerror_from_fixed_size_allocator (e8c0e07) during the generation of this report, so 1182150 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[overlookmotel]

lol, claude suggested this change while I was working on it, and I deliberately didn't do it because it felt like I was mixing the two concerns of the pool and the fixed size allocator.

This whole thing with fixed size allocators is held together with gaffer tape and string. It's a disaster area, and UB is only a slip of the keyboard away. Everything is entwined with each-other, and it's gratuitously unsound. So I don't think separation of concerns really applies - and that's the problem - there isn't any!

Iirc, it's also unsafe to call this function on a fixed size allocator if you didn't get it out of the pool?

Correct. But there's nowhere else to get one.

[graphite-app]

Merge activity

• Dec 18, 11:39 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Dec 18, 11:50 PM UTC: Merged by the Graphite merge queue.