refactor(allocator): simplify return type of FixedSizeAllocatorPool::create_new_allocator

[overlookmotel]

Follow-on after #17023. Pure refactor.

Returning Option<Result> was over-complicated. Just return Option.

[overlookmotel]

• docs(linter): fix typo in doc comment #17091
• test(linter/plugins): enable import plugin on one test fixture #17089
• perf(linter): avoid cloning source text when cloning AST into fixed-size allocator #17088
• refactor(linter): reduce repeat code in JS plugin linting #17087
• refactor(linter): reduce repeated logic in JS plugin linting #17086
• refactor(allocator): simplify return type of FixedSizeAllocatorPool::create_new_allocator #17080 👈 (View in Graphite)
• perf(allocator): reduce time Mutex lock is held in FixedSizeAllocatorPool::get #17079
• refactor(allocator): move nested function out of FixedSizeAllocatorPool::get #17078
• refactor(allocator): remove AllocError from fixed size allocator #17077
• fix(linter): OOM problems with custom plugins #17013
• feat(allocator): add cap to FixedSizeAllocatorPool and block when exhausted #17023
• refactor(allocator/fixed-size): return Result from allocation instead of panicking #17022
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17080 will not alter performance

_{Comparing om/12-18-refactor_allocator_simplify_return_type_of_fixedsizeallocatorpool_create_new_allocator_ (5fb89fb) with om/12-18-perf_allocator_reduce_time_mutex_lock_is_held_in_fixedsizeallocatorpool_get_ (8633439)¹}

Summary

✅ 42 untouched
⏩ 3 skipped²

Footnotes

1. No successful run was found on om/12-18-perf_allocator_reduce_time_mutex_lock_is_held_in_fixedsizeallocatorpool_get_ (2df9b9c) during the generation of this report, so 7f4438c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR simplifies the return type of FixedSizeAllocatorPool::create_new_allocator from Option<Result<FixedSizeAllocator, ()>> to Option<FixedSizeAllocator>, making the code more idiomatic and easier to read.

• Simplified return type eliminates unnecessary nesting since the error type () carries no information
• Updated caller to use cleaner pattern matching without nested Ok pattern
• Error handling logic is preserved through the use of result.ok() conversion

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Dec 18, 11:39 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Dec 18, 11:52 PM UTC: Merged by the Graphite merge queue.