refactor(allocator/fixed-size): return Result from allocation instead of panicking

[camc314]

No description provided.

[camc314]

• docs(linter): fix typo in doc comment #17091
• test(linter/plugins): enable import plugin on one test fixture #17089
• perf(linter): avoid cloning source text when cloning AST into fixed-size allocator #17088
• refactor(linter): reduce repeat code in JS plugin linting #17087
• refactor(linter): reduce repeated logic in JS plugin linting #17086
• refactor(allocator): simplify return type of FixedSizeAllocatorPool::create_new_allocator #17080
• perf(allocator): reduce time Mutex lock is held in FixedSizeAllocatorPool::get #17079
• refactor(allocator): move nested function out of FixedSizeAllocatorPool::get #17078
• refactor(allocator): remove AllocError from fixed size allocator #17077
• fix(linter): OOM problems with custom plugins #17013
• feat(allocator): add cap to FixedSizeAllocatorPool and block when exhausted #17023
• refactor(allocator/fixed-size): return Result from allocation instead of panicking #17022 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[camc314]

I didn't mark this as breaking as I don't believe FixedSizeAllocator is public

[Copilot]

Pull request overview

This PR refactors the fixed-size allocator to return a Result from allocation instead of panicking directly, making error handling more explicit while maintaining backward compatibility through immediate unwrapping at call sites. The change introduces a new AllocError type that captures allocation layout information for better error reporting.

Key Changes

• Introduced AllocError struct with Display and Error trait implementations for descriptive allocation failure messages
• Converted FixedSizeAllocator::new() to try_new() returning Result<Self, AllocError>
• Updated panic documentation in the public API to reflect allocation failure conditions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_allocator/src/pool/mod.rs	Updated documentation for the public get() method to document panic conditions for fixed-size allocator allocation failures
crates/oxc_allocator/src/pool/fixed_size.rs	Added AllocError type, refactored new() to try_new() returning Result, and removed direct panic via alloc::handle_alloc_error()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17022 will not alter performance

_{Comparing c/12-17-refactor_allocator_fixed-size_return_result_from_allocation_instead_of_panicking (63c3286) with main (005ec25)}

Summary

✅ 42 untouched
⏩ 3 skipped¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[overlookmotel]

Pushed a nit commit. Otherwise, all good.