refactor(allocator): remove AllocError from fixed size allocator

[overlookmotel]

Follow-on after #17022. AllocError type is pointless, as we never touch the contents of Result::Err. Remove it.

[overlookmotel]

• docs(linter): fix typo in doc comment #17091
• test(linter/plugins): enable import plugin on one test fixture #17089
• perf(linter): avoid cloning source text when cloning AST into fixed-size allocator #17088
• refactor(linter): reduce repeat code in JS plugin linting #17087
• refactor(linter): reduce repeated logic in JS plugin linting #17086
• refactor(allocator): simplify return type of FixedSizeAllocatorPool::create_new_allocator #17080
• perf(allocator): reduce time Mutex lock is held in FixedSizeAllocatorPool::get #17079
• refactor(allocator): move nested function out of FixedSizeAllocatorPool::get #17078
• refactor(allocator): remove AllocError from fixed size allocator #17077 👈 (View in Graphite)
• fix(linter): OOM problems with custom plugins #17013
• feat(allocator): add cap to FixedSizeAllocatorPool and block when exhausted #17023
• refactor(allocator/fixed-size): return Result from allocation instead of panicking #17022
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR refactors the fixed size allocator by removing the unused AllocError type and replacing it with the unit type () in error results. As noted in the description, the AllocError type was pointless since the error contents were never examined.

• Removed the AllocError struct definition and its Display and Error trait implementations
• Simplified error handling by using Result<T, ()> instead of Result<T, AllocError>
• Cleaned up unused imports (error::Error and fmt)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17077 will not alter performance

_{Comparing om/12-18-refactor_allocator_remove_allocerror_from_fixed_size_allocator (e8c0e07) with main (fb9e193)}

Summary

✅ 42 untouched
⏩ 3 skipped¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Dec 18, 11:39 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Dec 18, 11:49 PM UTC: Merged by the Graphite merge queue.