refactor(all)!: remove binding pattern wierdness

[camc314]

fixes #11489

Note, in quite a few places i changed the span we report on to look something like this, the only reason for this is to reduce the diff in some of the snapshots

decl.type_annotation.as_ref().map_or_else(
                        || decl.id.span(),
                        |type_annotation| decl.id.span().merge(type_annotation.span()),
                    ),

[camc314]

• feat(parser): change span for missing initializer in decleration #17134
• feat(parser): add diagnostic for parameters with question mark and initializer #17132
• refactor(all)!: remove binding pattern wierdness #15925 👈 (View in Graphite)
• chore(isolated-declarations): remove dead branch #17131
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #15925 will not alter performance

_{Comparing c/11-21-refactor_all_remove_binding_pattern_wierdness (4d4b85e) with main (2d556cb)}

Summary

✅ 42 untouched
⏩ 3 skipped¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

Merge activity

• Dec 22, 9:58 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 22, 10:04 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 22, 10:10 AM UTC: Merged by the Graphite merge queue.