Skip to content

feat(parser): add diagnostic for parameters with question mark and initializer#17132

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer
Dec 22, 2025
Merged

feat(parser): add diagnostic for parameters with question mark and initializer#17132
graphite-app[bot] merged 1 commit intomainfrom
c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 19, 2025

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Dec 19, 2025
Copy link
Contributor Author

camc314 commented Dec 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from f82e33f to 6701f1e Compare December 19, 2025 15:53
@camc314 camc314 force-pushed the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch from c276b62 to f953392 Compare December 19, 2025 15:53
@camc314 camc314 marked this pull request as ready for review December 19, 2025 15:59
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #17132 will not alter performance

Comparing c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer (ffe9ae2) with main (3984750)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from 6701f1e to 389357a Compare December 19, 2025 22:08
@camc314 camc314 force-pushed the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch 2 times, most recently from f2fc66d to be1a82d Compare December 19, 2025 22:11
@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from 389357a to 024c76b Compare December 19, 2025 22:11
@camc314 camc314 self-assigned this Dec 20, 2025
@camc314 camc314 force-pushed the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch from be1a82d to 93a5f9e Compare December 21, 2025 14:53
@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from 024c76b to d34598d Compare December 21, 2025 14:53
@camc314 camc314 force-pushed the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch from 93a5f9e to 32b9c4b Compare December 22, 2025 09:05
@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from d34598d to 8b119fe Compare December 22, 2025 09:05
@camc314 camc314 force-pushed the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch from 32b9c4b to 16728ff Compare December 22, 2025 09:57
@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from 8b119fe to 4d4b85e Compare December 22, 2025 09:57
@graphite-app graphite-app bot changed the base branch from c/11-21-refactor_all_remove_binding_pattern_wierdness to graphite-base/17132 December 22, 2025 10:04
@graphite-app graphite-app bot force-pushed the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch from 16728ff to d751de8 Compare December 22, 2025 10:12
@graphite-app graphite-app bot force-pushed the graphite-base/17132 branch from 4d4b85e to 3984750 Compare December 22, 2025 10:12
@graphite-app graphite-app bot changed the base branch from graphite-base/17132 to main December 22, 2025 10:12
@graphite-app graphite-app bot force-pushed the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch from d751de8 to ffe9ae2 Compare December 22, 2025 10:12
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 22, 2025
Copy link
Contributor Author

camc314 commented Dec 22, 2025

Merge activity

Copilot AI review requested due to automatic review settings December 22, 2025 10:24
@graphite-app graphite-app bot force-pushed the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch from ffe9ae2 to 3ee71b0 Compare December 22, 2025 10:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot merged commit 3ee71b0 into main Dec 22, 2025
27 checks passed
@graphite-app graphite-app bot deleted the c/12-19-feat_parser_add_diagnostic_for_parameters_with_question_mark_and_initializer branch December 22, 2025 10:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants