Skip to content

docs(ast): fix docs for AssignmentPattern in BindingPattern enum#17309

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-23-fix_ast_correct_docs_for_assignmentpattern_in_bindingpattern_enum
Dec 23, 2025
Merged

docs(ast): fix docs for AssignmentPattern in BindingPattern enum#17309
graphite-app[bot] merged 1 commit intomainfrom
c/12-23-fix_ast_correct_docs_for_assignmentpattern_in_bindingpattern_enum

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 23, 2025

follow on from #15925

@camc314 camc314 changed the base branch from c/12-23-feat_vscode_resolve_oxc.path.tsgolint_relative_to_workspace_root to graphite-base/17309 December 23, 2025 11:57
@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Dec 23, 2025
Copy link
Contributor Author

camc314 commented Dec 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 self-assigned this Dec 23, 2025
@camc314 camc314 added the C-docs Category - Documentation. Related to user-facing or internal documentation label Dec 23, 2025
@camc314 camc314 changed the title fix(ast): correct docs for AssignmentPattern in BindingPattern enum docs(ast): correct docs for AssignmentPattern in BindingPattern enum Dec 23, 2025
@camc314 camc314 changed the title docs(ast): correct docs for AssignmentPattern in BindingPattern enum docs(ast): fix docs for AssignmentPattern in BindingPattern enum Dec 23, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 23, 2025
@camc314 camc314 marked this pull request as ready for review December 23, 2025 11:58
Copy link
Contributor Author

camc314 commented Dec 23, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 23, 2025

CodSpeed Performance Report

Merging #17309 will not alter performance

Comparing c/12-23-fix_ast_correct_docs_for_assignmentpattern_in_bindingpattern_enum (63b29b2) with main (94a482b)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on graphite-base/17309 (c1d3e1a) during the generation of this report, so main (94a482b) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 changed the base branch from graphite-base/17309 to main December 23, 2025 12:25
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Dec 23, 2025
@camc314 camc314 force-pushed the c/12-23-fix_ast_correct_docs_for_assignmentpattern_in_bindingpattern_enum branch from 63b29b2 to 8986b7c Compare December 23, 2025 12:25
Copilot AI review requested due to automatic review settings December 23, 2025 12:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the documentation for the AssignmentPattern variant in the BindingPattern enum, as a follow-up to PR #15925 which refactored binding patterns. The documentation now correctly reflects that AssignmentPattern is not used in function parameters, as FormalParameter has its own initializer field for default values.

Key changes:

  • Removed incorrect examples showing AssignmentPattern in function parameter contexts (e.g., function f(x = 1) {})
  • Enhanced the "Invalid in" section with proper documentation links and clearer explanations
  • Added explicit references to FormalParameter::initializer and clarified syntax error cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot force-pushed the c/12-23-fix_ast_correct_docs_for_assignmentpattern_in_bindingpattern_enum branch from 8986b7c to 1005c0a Compare December 23, 2025 12:32
@graphite-app graphite-app bot merged commit 1005c0a into main Dec 23, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-23-fix_ast_correct_docs_for_assignmentpattern_in_bindingpattern_enum branch December 23, 2025 12:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-editor Area - Editor and Language Server C-bug Category - Bug C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants