Skip to content

chore(isolated-declarations): remove dead branch#17131

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-19-chore_isolated-declarations_remove_dead_branch
Dec 19, 2025
Merged

chore(isolated-declarations): remove dead branch#17131
graphite-app[bot] merged 1 commit intomainfrom
c/12-19-chore_isolated-declarations_remove_dead_branch

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 19, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review December 19, 2025 15:46
@camc314 camc314 requested a review from Dunqing as a code owner December 19, 2025 15:46
Copilot AI review requested due to automatic review settings December 19, 2025 15:46
@github-actions github-actions bot added A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 19, 2025
Copy link
Contributor Author

camc314 commented Dec 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
Copy link
Member

Dunqing commented Dec 19, 2025

Merge activity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a dead code branch from the infer_type_from_formal_parameter function. The removed code was checking if a formal parameter's pattern had a type annotation, but it never returned the result of that check, making it unreachable and ineffective.

Key Changes:

  • Removed 7 lines of dead code that checked param.pattern.type_annotation but never used the result

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #17131 will not alter performance

Comparing c/12-19-chore_isolated-declarations_remove_dead_branch (73d2946) with main (07faa5a)1

Summary

✅ 38 untouched
⏩ 7 skipped2

Footnotes

  1. No successful run was found on main (d56c27c) during the generation of this report, so 07faa5a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot force-pushed the c/12-19-chore_isolated-declarations_remove_dead_branch branch from 73d2946 to 42b8328 Compare December 19, 2025 15:52
@graphite-app graphite-app bot merged commit 42b8328 into main Dec 19, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-19-chore_isolated-declarations_remove_dead_branch branch December 19, 2025 15:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants