refactor(formatter): improve the code that was made for removing the binding pattern#17277
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #17277 will not alter performanceComparing Summary
Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the formatter code that handles function parameter formatting, improving code clarity and maintainability. The changes follow up on PR #15925 and simplify the implementation without changing behavior.
- Refactored
FormalParameterformatting to use memoization for better comment handling - Extracted common logic into a reusable
is_huggable_expressionhelper function - Simplified field access patterns by removing unnecessary method calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leaysgur
left a comment
There was a problem hiding this comment.
Oh, Prettier does not have tests for !... 👀
Merge activity
|
a16a902 to
cd069c0
Compare
cd069c0 to
28ee9a8
Compare
28ee9a8 to
bde0769
Compare
Yes, it's surprised me, and I found another regression from https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/20449000316/job/58758212726, which fixed in 28ee9a8 |

Follow up on #15925. Improved slightly to make it simpler.