refactor(diagnostic): remove path from sender
#15130
Merged
+27
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the diagnostic service to simplify the channel message type by embedding path information directly into Error objects instead of passing path-diagnostic tuples. The DiagnosticTuple type alias is removed, and all senders now transmit only Vec<Error> instead of (PathBuf, Vec<Error>).
- Simplified channel API by removing the
DiagnosticTupletype and changingDiagnosticSender/DiagnosticReceiverto handleVec<Error>directly - Updated all diagnostic sender call sites to send only diagnostic vectors
- Modified the diagnostic service to extract path information from error source codes instead of receiving it as tuple data
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_diagnostics/src/service.rs | Removed DiagnosticTuple type alias, updated channel types, modified run() to extract path from diagnostic source code |
| crates/oxc_diagnostics/src/lib.rs | Removed DiagnosticTuple from public exports |
| crates/oxc_linter/src/tsgolint.rs | Updated error sender to send only diagnostics vector |
| crates/oxc_linter/src/service/runtime.rs | Updated multiple error sender call sites to send only diagnostics vectors |
| crates/oxc_linter/src/lint_runner.rs | Updated error sender to send only diagnostics vector |
| apps/oxfmt/src/service.rs | Updated error sender call sites to send only diagnostics vectors |
Comments suppressed due to low confidence (1)
crates/oxc_diagnostics/src/service.rs:1
- The documentation example is outdated and no longer matches the new API. Since the channel now accepts
Vec<Error>instead of tuples, the example should be updated to usewrap_diagnosticsor demonstrate creating errors with source code attached. The current example code will not compile with the new signature.
use std::{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
force-pushed
the
c/10-30-refactor_diagnostic_remove_path_from_sender
branch
from
e797a3d to
e6ef83a
Compare
camc314
changed the base branch from
graphite-base/15130
to
c/10-30-chore_deps_update_dependency_oxc-miette_to_v2.6.0
graphite-app
bot
changed the base branch from
c/10-30-chore_deps_update_dependency_oxc-miette_to_v2.6.0
to
graphite-base/15130
CodSpeed Performance ReportMerging #15130 will not alter performanceComparing Summary
|
graphite-app
bot
force-pushed
the
graphite-base/15130
branch
from
78a108f to
3955335
Compare
graphite-app
bot
force-pushed
the
c/10-30-refactor_diagnostic_remove_path_from_sender
branch
from
e6ef83a to
f281003
Compare
graphite-app
bot
force-pushed
the
c/10-30-refactor_diagnostic_remove_path_from_sender
branch
from
f281003 to
6f9c859
Compare
Member
Merge activity
|
graphite-app
bot
force-pushed
the
c/10-30-refactor_diagnostic_remove_path_from_sender
branch
from
6f9c859 to
27b4f36
Compare
graphite-app
bot
deleted the
c/10-30-refactor_diagnostic_remove_path_from_sender
branch
leaysgur
added a commit
that referenced
this pull request
Nov 4, 2025
## [0.10.0] - 2025-11-04 ### 🚀 Features - 505252c formatter: Wrap parenthesis for AssignmentExpression that is a key of `PropertyDefinition` (#15243) (Dunqing) - 880b259 formatter: Align import-like formatting the same as Prettier (#15238) (Dunqing) - b77f254 oxfmt,formatter: Support `embeddedLanguageFormatting` option (#15216) (leaysgur) - 898d6fe oxfmt: Add embedded language formatting with Prettier integration (#14820) (Boshen) - e77a48e formatter: Detect code removal feature (#15059) (leaysgur) ### 🐛 Bug Fixes - daacf85 oxfmt: Release build fails (#15262) (Dunqing) - f5d0348 oxfmt: Sync `dependencies` with `npm/oxfmt` and `apps/oxfmt` (#15261) (leaysgur) - 46793d7 formatter: Correct printing comments for `LabeledStatement` (#15260) (Dunqing) - 831ae99 formatter: Multiple comments in `LogicalExpression` and `TSIntersectionType` (#15253) (Dunqing) - 5fa9b1e formatter: Should not indent `BinaryLikeExpression` when it is an argument of `Boolean` (#15250) (Dunqing) - 99e520f formatter: Handle chain expression for `JSXExpressionContainer` (#15242) (Dunqing) - a600bf5 formatter: Correct printing comments for `TaggedTemplateExpression` (#15241) (Dunqing) - a7289e7 formatter: Handle member chain for the call's parent is a chain expression (#15237) (Dunqing) ### 🚜 Refactor - 36ae721 formatter: Simplify the use of `indent` with `soft_line_break_or_space` (#15254) (Dunqing) - cdd8e2f formatter/sort-imports: Split sort_imports modules (#15189) (leaysgur) - 27b4f36 diagnostic: Remove `path` from sender (#15130) (camc314) - 85fb8e8 formatter/sort-imports: Pass options to is_ignored() (#15181) (leaysgur) ### 🧪 Testing - 9d5b34b formatter/sort-imports: Refactor sort_imports tests (#15188) (leaysgur) Co-authored-by: leaysgur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs oxc-project/oxc-miette#103