fix(formatter): handle member chain for the call's parent is a chain expression #15237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
CodSpeed Performance ReportMerging #15237 will not alter performanceComparing Summary
Footnotes
|
This was referenced Nov 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in member chain formatting by properly handling ChainExpression nodes in parent checks. The fix enables the formatter to correctly handle method chains with optional chaining expressions.
- Refactored code to use a
matchexpression for better readability and exhaustiveness checking - Introduced a new
without_chain_expression()helper method to skip ChainExpression wrapper nodes - Removed an unused intermediate variable (
parent) in theMemberChain::newmethod
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tasks/prettier_conformance/snapshots/prettier.js.snap.md | Updated compatibility score showing one previously failing test now passes |
| crates/oxc_formatter/src/utils/member_chain/mod.rs | Fixed bug by calling without_chain_expression() on parent, refactored if-else to match expression, removed unused variable |
| crates/oxc_formatter/src/ast_nodes/impls/ast_nodes.rs | Added new helper method to recursively skip ChainExpression wrapper nodes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dunqing
force-pushed
the
11-03-fix_formatter_handle_member_chain_for_the_call_s_parent_is_a_chain_expression
branch
from
c9c0c63 to
53f09b5
Compare
This was referenced Nov 4, 2025
Merged
Contributor
Merge activity
|
…expression (#15237) This is an error-prone situation because Biome didn't have a ChainExpression. However, we have to handle it on a case-by-case basis.
graphite-app
bot
force-pushed
the
11-03-fix_formatter_handle_member_chain_for_the_call_s_parent_is_a_chain_expression
branch
from
53f09b5 to
a7289e7
Compare
graphite-app
bot
deleted the
11-03-fix_formatter_handle_member_chain_for_the_call_s_parent_is_a_chain_expression
branch
leaysgur
added a commit
that referenced
this pull request
Nov 4, 2025
## [0.10.0] - 2025-11-04 ### 🚀 Features - 505252c formatter: Wrap parenthesis for AssignmentExpression that is a key of `PropertyDefinition` (#15243) (Dunqing) - 880b259 formatter: Align import-like formatting the same as Prettier (#15238) (Dunqing) - b77f254 oxfmt,formatter: Support `embeddedLanguageFormatting` option (#15216) (leaysgur) - 898d6fe oxfmt: Add embedded language formatting with Prettier integration (#14820) (Boshen) - e77a48e formatter: Detect code removal feature (#15059) (leaysgur) ### 🐛 Bug Fixes - daacf85 oxfmt: Release build fails (#15262) (Dunqing) - f5d0348 oxfmt: Sync `dependencies` with `npm/oxfmt` and `apps/oxfmt` (#15261) (leaysgur) - 46793d7 formatter: Correct printing comments for `LabeledStatement` (#15260) (Dunqing) - 831ae99 formatter: Multiple comments in `LogicalExpression` and `TSIntersectionType` (#15253) (Dunqing) - 5fa9b1e formatter: Should not indent `BinaryLikeExpression` when it is an argument of `Boolean` (#15250) (Dunqing) - 99e520f formatter: Handle chain expression for `JSXExpressionContainer` (#15242) (Dunqing) - a600bf5 formatter: Correct printing comments for `TaggedTemplateExpression` (#15241) (Dunqing) - a7289e7 formatter: Handle member chain for the call's parent is a chain expression (#15237) (Dunqing) ### 🚜 Refactor - 36ae721 formatter: Simplify the use of `indent` with `soft_line_break_or_space` (#15254) (Dunqing) - cdd8e2f formatter/sort-imports: Split sort_imports modules (#15189) (leaysgur) - 27b4f36 diagnostic: Remove `path` from sender (#15130) (camc314) - 85fb8e8 formatter/sort-imports: Pass options to is_ignored() (#15181) (leaysgur) ### 🧪 Testing - 9d5b34b formatter/sort-imports: Refactor sort_imports tests (#15188) (leaysgur) Co-authored-by: leaysgur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an error-prone situation because Biome didn't have a ChainExpression. However, we have to handle it on a case-by-case basis.