Skip to content

fix(formatter): handle chain expression for JSXExpressionContainer #15242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

fix(formatter): handle chain expression for JSXExpressionContainer #15242

merged 1 commit into from
Nov 4, 2025

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 3, 2025 •
edited
Loading

Same as #15237

@github-actions github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Nov 3, 2025
This was referenced Nov 3, 2025
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Nov 3, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Nov 3, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15242 will not alter performance

Comparing 11-03-fix_formatter_handle_chain_expression_for_jsxexpressioncontainer (46ada31) with 11-03-fix_formatter_correct_printing_comments_for_taggedtemplateexpression (07c81e3)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing Dunqing mentioned this pull request Nov 3, 2025
Merged
@Dunqing Dunqing marked this pull request as ready for review November 4, 2025 00:38
@Dunqing Dunqing force-pushed the 11-03-fix_formatter_correct_printing_comments_for_taggedtemplateexpression branch from 111be2b to c2bdaa5 Compare November 4, 2025 01:00
@Dunqing Dunqing force-pushed the 11-03-fix_formatter_handle_chain_expression_for_jsxexpressioncontainer branch 2 times, most recently from 768711e to a3eac2a Compare November 4, 2025 02:19
@Dunqing Dunqing force-pushed the 11-03-fix_formatter_correct_printing_comments_for_taggedtemplateexpression branch 2 times, most recently from ff6e99c to 07c81e3 Compare November 4, 2025 02:23
@Dunqing Dunqing force-pushed the 11-03-fix_formatter_handle_chain_expression_for_jsxexpressioncontainer branch from a3eac2a to 46ada31 Compare November 4, 2025 02:23
This was referenced Nov 4, 2025
Merged
Merged
Merged
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 4, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 11-03-fix_formatter_correct_printing_comments_for_taggedtemplateexpression branch from 07c81e3 to a600bf5 Compare November 4, 2025 06:39
@graphite-app graphite-app bot force-pushed the 11-03-fix_formatter_handle_chain_expression_for_jsxexpressioncontainer branch from 46ada31 to 99e520f Compare November 4, 2025 06:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 4, 2025
Base automatically changed from 11-03-fix_formatter_correct_printing_comments_for_taggedtemplateexpression to main November 4, 2025 06:46
@graphite-app graphite-app bot merged commit 99e520f into main Nov 4, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-03-fix_formatter_handle_chain_expression_for_jsxexpressioncontainer branch November 4, 2025 06:47
@Boshen Boshen mentioned this pull request Nov 4, 2025
Merged
leaysgur added a commit that referenced this pull request Nov 4, 2025
@Boshen @leaysgur
release(oxfmt): v0.10.0 (#15263)
b4ebdf5 
## [0.10.0] - 2025-11-04

### 🚀 Features

- 505252c formatter: Wrap parenthesis for AssignmentExpression that is a
key of `PropertyDefinition` (#15243) (Dunqing)
- 880b259 formatter: Align import-like formatting the same as Prettier
(#15238) (Dunqing)
- b77f254 oxfmt,formatter: Support `embeddedLanguageFormatting` option
(#15216) (leaysgur)
- 898d6fe oxfmt: Add embedded language formatting with Prettier
integration (#14820) (Boshen)
- e77a48e formatter: Detect code removal feature (#15059) (leaysgur)

### 🐛 Bug Fixes

- daacf85 oxfmt: Release build fails (#15262) (Dunqing)
- f5d0348 oxfmt: Sync `dependencies` with `npm/oxfmt` and `apps/oxfmt`
(#15261) (leaysgur)
- 46793d7 formatter: Correct printing comments for `LabeledStatement`
(#15260) (Dunqing)
- 831ae99 formatter: Multiple comments in `LogicalExpression` and
`TSIntersectionType` (#15253) (Dunqing)
- 5fa9b1e formatter: Should not indent `BinaryLikeExpression` when it is
an argument of `Boolean` (#15250) (Dunqing)
- 99e520f formatter: Handle chain expression for
`JSXExpressionContainer` (#15242) (Dunqing)
- a600bf5 formatter: Correct printing comments for
`TaggedTemplateExpression` (#15241) (Dunqing)
- a7289e7 formatter: Handle member chain for the call's parent is a
chain expression (#15237) (Dunqing)

### 🚜 Refactor

- 36ae721 formatter: Simplify the use of `indent` with
`soft_line_break_or_space` (#15254) (Dunqing)
- cdd8e2f formatter/sort-imports: Split sort_imports modules (#15189)
(leaysgur)
- 27b4f36 diagnostic: Remove `path` from sender (#15130) (camc314)
- 85fb8e8 formatter/sort-imports: Pass options to is_ignored() (#15181)
(leaysgur)

### 🧪 Testing

- 9d5b34b formatter/sort-imports: Refactor sort_imports tests (#15188)
(leaysgur)

Co-authored-by: leaysgur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dunqing