Skip to content

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Oct 31, 2025

  • before: sort_imports.rs
  • after: sort_imports/mod.rs + 3 files

@leaysgur leaysgur requested a review from Dunqing as a code owner October 31, 2025 08:50
@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 31, 2025
Copy link
Member Author

leaysgur commented Oct 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 31, 2025

CodSpeed Performance Report

Merging #15189 will not alter performance

Comparing 10-31-refactor_formatter_sort-imports_split_sort_imports_modules (4f71a64) with 10-31-test_formatter_sort-imports_refactor_sort_imports_tests (6446aca)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 3, 2025
Copy link
Member

Dunqing commented Nov 3, 2025

Merge activity

- before: sort_imports.rs
- after: sort_imports/mod.rs + 3 files
@graphite-app graphite-app bot force-pushed the 10-31-test_formatter_sort-imports_refactor_sort_imports_tests branch from 6446aca to 9d5b34b Compare November 3, 2025 01:40
@graphite-app graphite-app bot force-pushed the 10-31-refactor_formatter_sort-imports_split_sort_imports_modules branch from 4f71a64 to cdd8e2f Compare November 3, 2025 01:40
Base automatically changed from 10-31-test_formatter_sort-imports_refactor_sort_imports_tests to main November 3, 2025 01:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 3, 2025
@graphite-app graphite-app bot merged commit cdd8e2f into main Nov 3, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-31-refactor_formatter_sort-imports_split_sort_imports_modules branch November 3, 2025 01:46
@Boshen Boshen mentioned this pull request Nov 4, 2025
leaysgur added a commit that referenced this pull request Nov 4, 2025
## [0.10.0] - 2025-11-04

### 🚀 Features

- 505252c formatter: Wrap parenthesis for AssignmentExpression that is a
key of `PropertyDefinition` (#15243) (Dunqing)
- 880b259 formatter: Align import-like formatting the same as Prettier
(#15238) (Dunqing)
- b77f254 oxfmt,formatter: Support `embeddedLanguageFormatting` option
(#15216) (leaysgur)
- 898d6fe oxfmt: Add embedded language formatting with Prettier
integration (#14820) (Boshen)
- e77a48e formatter: Detect code removal feature (#15059) (leaysgur)

### 🐛 Bug Fixes

- daacf85 oxfmt: Release build fails (#15262) (Dunqing)
- f5d0348 oxfmt: Sync `dependencies` with `npm/oxfmt` and `apps/oxfmt`
(#15261) (leaysgur)
- 46793d7 formatter: Correct printing comments for `LabeledStatement`
(#15260) (Dunqing)
- 831ae99 formatter: Multiple comments in `LogicalExpression` and
`TSIntersectionType` (#15253) (Dunqing)
- 5fa9b1e formatter: Should not indent `BinaryLikeExpression` when it is
an argument of `Boolean` (#15250) (Dunqing)
- 99e520f formatter: Handle chain expression for
`JSXExpressionContainer` (#15242) (Dunqing)
- a600bf5 formatter: Correct printing comments for
`TaggedTemplateExpression` (#15241) (Dunqing)
- a7289e7 formatter: Handle member chain for the call's parent is a
chain expression (#15237) (Dunqing)

### 🚜 Refactor

- 36ae721 formatter: Simplify the use of `indent` with
`soft_line_break_or_space` (#15254) (Dunqing)
- cdd8e2f formatter/sort-imports: Split sort_imports modules (#15189)
(leaysgur)
- 27b4f36 diagnostic: Remove `path` from sender (#15130) (camc314)
- 85fb8e8 formatter/sort-imports: Pass options to is_ignored() (#15181)
(leaysgur)

### 🧪 Testing

- 9d5b34b formatter/sort-imports: Refactor sort_imports tests (#15188)
(leaysgur)

Co-authored-by: leaysgur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants