Skip to content

feat(linter): pretty print tsgolint internal diagnostics #15131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

feat(linter): pretty print tsgolint internal diagnostics #15131

merged 1 commit into from
Nov 3, 2025
+12 −4

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 30, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Oct 30, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 30, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Oct 30, 2025
Merged
@camc314 camc314 marked this pull request as ready for review October 30, 2025 13:57
@camc314 camc314 self-assigned this Oct 30, 2025
@camc314 camc314 force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from 4a6ef1d to 13325cf Compare October 30, 2025 15:26
@camc314 camc314 force-pushed the c/10-30-refactor_diagnostic_remove_path_from_sender branch from e797a3d to e6ef83a Compare October 30, 2025 15:26
@camc314 camc314 mentioned this pull request Oct 30, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15131 will not alter performance

Comparing c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics (92db9d7) with main (096fb2c)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app bot force-pushed the c/10-30-refactor_diagnostic_remove_path_from_sender branch 2 times, most recently from f281003 to 6f9c859 Compare October 30, 2025 15:39
@graphite-app graphite-app bot force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from 13325cf to 5bd6072 Compare October 30, 2025 15:39
@graphite-app graphite-app bot changed the base branch from c/10-30-refactor_diagnostic_remove_path_from_sender to graphite-base/15131 October 31, 2025 07:43
@graphite-app graphite-app bot force-pushed the graphite-base/15131 branch from 6f9c859 to 27b4f36 Compare October 31, 2025 07:50
@graphite-app graphite-app bot force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from 5bd6072 to e235398 Compare October 31, 2025 07:50
@graphite-app graphite-app bot changed the base branch from graphite-base/15131 to main October 31, 2025 07:50
@graphite-app graphite-app bot force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from e235398 to f6c3104 Compare October 31, 2025 07:51
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 31, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 31, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Oct 31, 11:06 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 31, 11:06 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Oct 31, 11:11 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test Linux').
  • Oct 31, 11:12 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 31, 11:12 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Nov 3, 1:14 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 3, 1:15 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 3, 1:21 PM UTC: Merged by the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Oct 31, 2025
@camc314
feat(linter): pretty print tsgolint internal diagnostics (#15131)
41725c7
@graphite-app graphite-app bot force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from f6c3104 to 41725c7 Compare October 31, 2025 11:06
Copilot AI review requested due to automatic review settings October 31, 2025 11:06
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

graphite-app bot pushed a commit that referenced this pull request Oct 31, 2025
@camc314
feat(linter): pretty print tsgolint internal diagnostics (#15131)
bafb951
@graphite-app graphite-app bot force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from 41725c7 to bafb951 Compare October 31, 2025 11:07
graphite-app bot pushed a commit that referenced this pull request Oct 31, 2025
@camc314
feat(linter): pretty print tsgolint internal diagnostics (#15131)
46e2f06
@graphite-app graphite-app bot force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from bafb951 to 46e2f06 Compare October 31, 2025 11:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 31, 2025
camc314 added a commit that referenced this pull request Nov 2, 2025
@camc314
feat(linter): pretty print tsgolint internal diagnostics (#15131)
92db9d7
@camc314 camc314 force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from 46e2f06 to 92db9d7 Compare November 2, 2025 23:13
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 3, 2025
@graphite-app graphite-app bot force-pushed the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch from 92db9d7 to 979ec04 Compare November 3, 2025 13:15
@graphite-app graphite-app bot merged commit 979ec04 into main Nov 3, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/10-30-feat_linter_pretty_print_tsgolint_internal_diagnostics branch November 3, 2025 13:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 3, 2025
@Boshen Boshen mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314