feat(linter): convert spans to UTF-16 in JS plugins#13344
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 28, 2025
Merged
feat(linter): convert spans to UTF-16 in JS plugins#13344graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Aug 27, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 27, 2025
CodSpeed Instrumentation Performance ReportMerging #13344 will not alter performanceComparing Summary
Footnotes |
Contributor
Merge activity
|
graphite-app
bot
changed the base branch from
08-27-feat_semantic_derive_default_for_semantic_
to
graphite-base/13344
The AST on JS side in linter JS plugins previously had `start` and `end` as UTF-8 offsets. Convert the AST to UTF-16 offsets prior to transferring it to JS, and convert offsets in any errors/warnings returned from JS side back to UTF-8 before creating `OxcDiagnostic`s from them. The tricky part is that it's not possible to mutate the AST (convert offsets to UTF-16) while `Semantic` is alive, because you can't obtain a `&mut Program` due to aliasing rules. Work around this with some pointer juggling and by dropping `Semantic` before creating a `&mut Program`. This is a bit sketchy, but is not (I believe) UB. Hopefully we can remove the need for this workaround later on by performing offset conversion during serialization / raw transfer deserialization, and so avoid the need to mutate the AST.
graphite-app
bot
force-pushed
the
08-27-fix_napi_oxlint_convert_spans_to_utf-16
branch
from
9ba81d3 to
d1c9db5
Compare
graphite-app
bot
deleted the
08-27-fix_napi_oxlint_convert_spans_to_utf-16
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AST on JS side in linter JS plugins previously had
startandendas UTF-8 offsets.Convert the AST to UTF-16 offsets prior to transferring it to JS, and convert offsets in any errors/warnings returned from JS side back to UTF-8 before creating
OxcDiagnostics from them.The tricky part is that it's not possible to mutate the AST (convert offsets to UTF-16) while
Semanticis alive, because you can't obtain a&mut Programdue to aliasing rules. Work around this with some pointer juggling and by droppingSemanticbefore creating a&mut Program.This is a bit sketchy, but is not (I believe) UB. Hopefully we can remove the need for this workaround later on by performing offset conversion during serialization / raw transfer deserialization, and so avoid the need to mutate the AST.