Skip to content

Comments

feat(ast_visit): Utf8ToUtf16 translate back from UTF-16 to UTF-8#13340

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8
Aug 28, 2025
Merged

feat(ast_visit): Utf8ToUtf16 translate back from UTF-16 to UTF-8#13340
graphite-app[bot] merged 1 commit intomainfrom
08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 27, 2025

Add methods convert_offset_back and convert_span_back to Utf8ToUtf16, to convert UTF-16 offsets back to UTF-8. We'll use this in linter JS plugins to convert spans for errors/warnings coming from JS side.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Aug 27, 2025
Copy link
Member Author

overlookmotel commented Aug 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2025

CodSpeed Instrumentation Performance Report

Merging #13340 will not alter performance

Comparing 08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8 (59d2c08) with main (33e0e8b)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (cd5a9ca) during the generation of this report, so 33e0e8b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review August 27, 2025 22:24
@overlookmotel overlookmotel marked this pull request as draft August 27, 2025 22:56
@overlookmotel overlookmotel force-pushed the 08-27-refactor_ast_visit_utf8toutf16_record_end_offset_of_multi-byte_chars branch from e579c71 to 7554d37 Compare August 27, 2025 23:01
@overlookmotel overlookmotel force-pushed the 08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8 branch from e326655 to 462e488 Compare August 27, 2025 23:01
@overlookmotel overlookmotel marked this pull request as ready for review August 27, 2025 23:01
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 28, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 28, 2025

Merge activity

…13340)

Add methods `convert_offset_back` and `convert_span_back` to `Utf8ToUtf16`, to convert UTF-16 offsets back to UTF-8. We'll use this in linter JS plugins to convert spans for errors/warnings coming from JS side.
@graphite-app graphite-app bot force-pushed the 08-27-refactor_ast_visit_utf8toutf16_record_end_offset_of_multi-byte_chars branch from 7554d37 to cd5a9ca Compare August 28, 2025 09:24
@graphite-app graphite-app bot force-pushed the 08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8 branch from 462e488 to 59d2c08 Compare August 28, 2025 09:24
Base automatically changed from 08-27-refactor_ast_visit_utf8toutf16_record_end_offset_of_multi-byte_chars to main August 28, 2025 09:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 28, 2025
@graphite-app graphite-app bot merged commit 59d2c08 into main Aug 28, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-27-feat_ast_visit_utf8toutf16_translate_back_from_utf-16_to_utf-8 branch August 28, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants