Skip to content

Comments

feat(semantic): derive Default for Semantic#13343

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-27-feat_semantic_derive_default_for_semantic_
Aug 28, 2025
Merged

feat(semantic): derive Default for Semantic#13343
graphite-app[bot] merged 1 commit intomainfrom
08-27-feat_semantic_derive_default_for_semantic_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 27, 2025

After #13336, we can derive Default on Semantic.

This is not so useful in most cases, but does allow using std::mem::take on a &mut Semantic, which is used in next PR in this stack.

Copy link
Member Author

overlookmotel commented Aug 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2025

CodSpeed Instrumentation Performance Report

Merging #13343 will not alter performance

Comparing 08-27-feat_semantic_derive_default_for_semantic_ (9a828de) with main (33e0e8b)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (9a828de) during the generation of this report, so 33e0e8b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 28, 2025
Copy link
Member Author

overlookmotel commented Aug 28, 2025

Merge activity

After #13336, we can derive `Default` on `Semantic`.

This is not so useful in most cases, but does allow using `std::mem::take` on a `&mut Semantic`, which is used in next PR in this stack.
@graphite-app graphite-app bot force-pushed the 08-27-feat_ast_visit_add_utf8toutf16converter_convert_program_method branch from 2f29200 to bb10c88 Compare August 28, 2025 09:25
@graphite-app graphite-app bot force-pushed the 08-27-feat_semantic_derive_default_for_semantic_ branch from cc7f880 to 9a828de Compare August 28, 2025 09:25
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 28, 2025
Base automatically changed from 08-27-feat_ast_visit_add_utf8toutf16converter_convert_program_method to main August 28, 2025 09:30
@graphite-app graphite-app bot merged commit 9a828de into main Aug 28, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-27-feat_semantic_derive_default_for_semantic_ branch August 28, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants