refactor(ast_visit): Utf8ToUtf16 record end offset of multi-byte chars#13339
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 28, 2025
Conversation
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 27, 2025
CodSpeed Instrumentation Performance ReportMerging #13339 will not alter performanceComparing Summary
Footnotes |
overlookmotel
force-pushed
the
08-27-refactor_ast_visit_utf8toutf16_record_end_offset_of_multi-byte_chars
branch
from
e579c71 to
7554d37
Compare
This was referenced Aug 27, 2025
Dunqing
approved these changes
Aug 28, 2025
Contributor
Merge activity
|
…ars (#13339) `Utf8ToUtf16` converter creates a table of translations from UTF-8 offset to UTF-16 offset. Previously it recorded UTF-8 offsets as the start of the multi-byte character + 1. This PR changes that to record the offset of the *end* of character. This costs a couple more instructions when adding records to the table, but makes no difference to the amount of work involved in converting offsets. The advantages are: 1. Reduces complexity due to not having to handle edge cases where arithmetic overflow was possible previously. 2. Makes it possible to use the same table to convert back from UTF-16 to UTF-8 (next PR in this stack). As Unicode chars are rare, and the extra cost is small anyway, I think this trade-off is worth it.
graphite-app
bot
force-pushed
the
08-27-refactor_ast_visit_utf8toutf16_record_end_offset_of_multi-byte_chars
branch
from
7554d37 to
cd5a9ca
Compare
graphite-app
bot
deleted the
08-27-refactor_ast_visit_utf8toutf16_record_end_offset_of_multi-byte_chars
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utf8ToUtf16converter creates a table of translations from UTF-8 offset to UTF-16 offset.Previously it recorded UTF-8 offsets as the start of the multi-byte character + 1. This PR changes that to record the offset of the end of character.
This costs a couple more instructions when adding records to the table, but makes no difference to the amount of work involved in converting offsets.
The advantages are:
As Unicode chars are rare, and the extra cost is small anyway, I think this trade-off is worth it.